-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
site: Add docs for header manipualtion with Ingress #4279
site: Add docs for header manipualtion with Ingress #4279
Conversation
Fixes: projectcontour#4102 Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Codecov Report
@@ Coverage Diff @@
## main #4279 +/- ##
==========================================
+ Coverage 77.74% 77.80% +0.06%
==========================================
Files 112 112
Lines 10014 10022 +8
==========================================
+ Hits 7785 7798 +13
+ Misses 2046 2042 -4
+ Partials 183 182 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, however while reviewing I couldn't find a link to this page in the TOC - am I missing it? If it's not there, we should add, otherwise I'm not sure how folks find this page.
no i think i forgot to add it when i added this page, adding now see https://deploy-preview-4279--projectcontour.netlify.app/docs/main/ |
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks like this page needs an update for recently-merged #4271 too, I'll put a PR up for that. |
Fixes: #4102