Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site: Add docs for header manipualtion with Ingress #4279

Merged
merged 3 commits into from
Jan 20, 2022

Conversation

sunjayBhatia
Copy link
Member

Fixes: #4102

Fixes: projectcontour#4102

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
@sunjayBhatia sunjayBhatia added the release-note/docs A documentation change for the release notes. label Jan 19, 2022
@sunjayBhatia sunjayBhatia requested a review from a team as a code owner January 19, 2022 15:10
@sunjayBhatia sunjayBhatia requested review from skriss and youngnick and removed request for a team January 19, 2022 15:10
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #4279 (d30da37) into main (81dd7c9) will increase coverage by 0.06%.
The diff coverage is 63.63%.

❗ Current head d30da37 differs from pull request most recent head f1eaca4. Consider uploading reports for the commit f1eaca4 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4279      +/-   ##
==========================================
+ Coverage   77.74%   77.80%   +0.06%     
==========================================
  Files         112      112              
  Lines       10014    10022       +8     
==========================================
+ Hits         7785     7798      +13     
+ Misses       2046     2042       -4     
+ Partials      183      182       -1     
Impacted Files Coverage Δ
internal/certgen/certgen.go 71.73% <0.00%> (-1.60%) ⬇️
internal/annotation/annotations.go 100.00% <100.00%> (ø)
internal/dag/ingress_processor.go 97.53% <100.00%> (+4.32%) ⬆️
internal/k8s/objectmeta.go 93.75% <100.00%> (+0.89%) ⬆️

Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, however while reviewing I couldn't find a link to this page in the TOC - am I missing it? If it's not there, we should add, otherwise I'm not sure how folks find this page.

@sunjayBhatia
Copy link
Member Author

sunjayBhatia commented Jan 19, 2022

Changes LGTM, however while reviewing I couldn't find a link to this page in the TOC - am I missing it? If it's not there, we should add, otherwise I'm not sure how folks find this page.

no i think i forgot to add it when i added this page, adding now

see https://deploy-preview-4279--projectcontour.netlify.app/docs/main/

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skriss
Copy link
Member

skriss commented Jan 19, 2022

Looks like this page needs an update for recently-merged #4271 too, I'll put a PR up for that.

@youngnick youngnick merged commit 2b86d8e into projectcontour:main Jan 20, 2022
@sunjayBhatia sunjayBhatia deleted the ingress-header-docs branch January 20, 2022 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/docs A documentation change for the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Document default Ingress headers
3 participants