internal/{dag,contour}: reimplement kubernetes/ingress.class support #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes projectcontour#483 Reimplement ingress.class support in contour's DAGAdapter. There is some trickiness in ensuring that if an ingress is edited from valid (matching the ingress.class rules) to invalid then the previous version needs to be purged from the DAG cache. The internal/e2e tests now capture this. Signed-off-by: Dave Cheney <dave@cheney.net>
davecheney
changed the title
sunjayBhatia
pushed a commit
that referenced
this pull request
Jan 30, 2023
Signed-off-by: Steve Kriss <krisss@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #483
Reimplement ingress.class support in contour's DAGAdapter. There is some
trickiness in ensuring that if an ingress is edited from valid (matching
the ingress.class rules) to invalid then the previous version needs to
be purged from the DAG cache. The internal/e2e tests now capture this.
Signed-off-by: Dave Cheney dave@cheney.net