-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow changing per_connection_buffer_limit_bytes using contour configuration for listeners #5513
Merged
sunjayBhatia
merged 4 commits into
projectcontour:main
from
rajatvig:configlistener_bytes
Jul 13, 2023
Merged
Allow changing per_connection_buffer_limit_bytes using contour configuration for listeners #5513
sunjayBhatia
merged 4 commits into
projectcontour:main
from
rajatvig:configlistener_bytes
Jul 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5513 +/- ##
==========================================
+ Coverage 78.38% 78.46% +0.08%
==========================================
Files 138 138
Lines 18869 18908 +39
==========================================
+ Hits 14791 14837 +46
+ Misses 3795 3790 -5
+ Partials 283 281 -2
|
skriss
requested changes
Jun 21, 2023
…uration for listeners Signed-off-by: Rajat Vig <rvig@etsy.com>
Signed-off-by: Rajat Vig <rvig@etsy.com>
8cee823
to
128e6a0
Compare
skriss
reviewed
Jun 26, 2023
Signed-off-by: Rajat Vig <rvig@etsy.com>
Signed-off-by: Rajat Vig <rvig@etsy.com>
skriss
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @rajatvig!
sunjayBhatia
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release-note/minor
A minor change that needs about a paragraph of explanation in the release notes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5263
Fixes #1407