Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing per_connection_buffer_limit_bytes using contour configuration for listeners #5513

Merged
merged 4 commits into from
Jul 13, 2023

Conversation

rajatvig
Copy link
Member

@rajatvig rajatvig commented Jun 21, 2023

Fixes #5263
Fixes #1407

@rajatvig rajatvig added the release-note/minor A minor change that needs about a paragraph of explanation in the release notes. label Jun 21, 2023
@rajatvig rajatvig marked this pull request as ready for review June 21, 2023 11:23
@rajatvig rajatvig requested a review from a team as a code owner June 21, 2023 11:23
@rajatvig rajatvig requested review from stevesloka, sunjayBhatia, tsaarni and skriss and removed request for a team, stevesloka and sunjayBhatia June 21, 2023 11:23
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #5513 (c2614c1) into main (d802a88) will increase coverage by 0.08%.
The diff coverage is 48.64%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5513      +/-   ##
==========================================
+ Coverage   78.38%   78.46%   +0.08%     
==========================================
  Files         138      138              
  Lines       18869    18908      +39     
==========================================
+ Hits        14791    14837      +46     
+ Misses       3795     3790       -5     
+ Partials      283      281       -2     
Impacted Files Coverage Δ
cmd/contour/serve.go 20.08% <0.00%> (-0.03%) ⬇️
cmd/contour/servecontext.go 83.33% <100.00%> (+0.03%) ⬆️
internal/envoy/v3/listener.go 98.48% <100.00%> (+<0.01%) ⬆️
internal/xdscache/v3/listener.go 92.33% <100.00%> (+0.06%) ⬆️
pkg/config/parameters.go 86.26% <100.00%> (+0.13%) ⬆️

... and 10 files with indirect coverage changes

rajatvig added 2 commits June 24, 2023 00:19
…uration for listeners

Signed-off-by: Rajat Vig <rvig@etsy.com>
Signed-off-by: Rajat Vig <rvig@etsy.com>
rajatvig added 2 commits July 8, 2023 22:37
Signed-off-by: Rajat Vig <rvig@etsy.com>
Signed-off-by: Rajat Vig <rvig@etsy.com>
Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @rajatvig!

@skriss skriss requested a review from sunjayBhatia July 10, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/minor A minor change that needs about a paragraph of explanation in the release notes.
Projects
None yet
3 participants