Remove static base runtime layer from bootstrap #6063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubronzhan
requested review from
skriss and
sunjayBhatia
and removed request for
a team
sunjayBhatia
requested review from
a team and
davinci26
and removed request for
a team
Signed-off-by: lubronzhan <lzhan@vmware.com>
lubronzhan
force-pushed
the
topic/lubron/fix-5845
branch
from
7e32f23 to
0290f8b
Compare
|
Hi @lubronzhan! Welcome to our community and thank you for opening your first Pull Request. Someone will review it soon. Thank you for committing to making Contour better. You can also join us on our mailing list and in our channel in the Kubernetes Slack Workspace |
Signed-off-by: lubronzhan <lzhan@vmware.com>
lubronzhan
force-pushed
the
topic/lubron/fix-5845
branch
from
0d71e6f to
f9c40b7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6063 +/- ##
==========================================
+ Coverage 78.51% 78.78% +0.27%
==========================================
Files 138 138
Lines 18930 19744 +814
==========================================
+ Hits 14862 15556 +694
- Misses 3787 3885 +98
- Partials 281 303 +22
|
sunjayBhatia
added
the
release-note/small
|
Can ignore the test-osx failure, it is a race related to: #6055 |
sunjayBhatia
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now dynamic runtime layer is available, they add the same config, so the static layer could be removed
Fix #5845