Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go to 1.21.6 #6070

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Conversation

sunjayBhatia
Copy link
Member

See release notes: https://go.dev/doc/devel/release#go1.21.0

Uses sha for golang image to pin it exactly

May help with test race issues that cropped up recently

See release notes: https://go.dev/doc/devel/release#go1.21.0

Uses sha for golang image to pin it exactly

May help with test race issues that cropped up recently

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
@sunjayBhatia sunjayBhatia added the release-note/small A small change that needs one line of explanation in the release notes. label Jan 11, 2024
@sunjayBhatia sunjayBhatia requested a review from a team as a code owner January 11, 2024 17:01
@sunjayBhatia sunjayBhatia requested review from tsaarni, skriss, a team and davinci26 and removed request for a team January 11, 2024 17:01
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d8931d4) 78.81% compared to head (6fa6f19) 78.81%.

❗ Current head 6fa6f19 differs from pull request most recent head 3e93ec5. Consider uploading reports for the commit 3e93ec5 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6070   +/-   ##
=======================================
  Coverage   78.81%   78.81%           
=======================================
  Files         138      138           
  Lines       19778    19778           
=======================================
  Hits        15589    15589           
  Misses       3886     3886           
  Partials      303      303           

@sunjayBhatia
Copy link
Member Author

Ha, well that pretty obviously didnt fix anything: https://github.com/projectcontour/contour/actions/runs/7492048159/job/20394801572?pr=6070

@sunjayBhatia sunjayBhatia enabled auto-merge (squash) January 11, 2024 17:23
@sunjayBhatia sunjayBhatia merged commit 838bad4 into projectcontour:main Jan 11, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/small A small change that needs one line of explanation in the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants