Fix for specifying a health check port with an ExternalName Service #6230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yangyang <yang.yang@daocloud.io>
yangyy93
requested review from
skriss and
sunjayBhatia
and removed request for
a team
sunjayBhatia
requested review from
a team,
izturn and
clayton-gonsalves
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6230 +/- ##
=======================================
Coverage 81.33% 81.33%
=======================================
Files 133 133
Lines 15772 15775 +3
=======================================
+ Hits 12828 12831 +3
Misses 2650 2650
Partials 294 294
|
tsaarni
reviewed
Feb 29, 2024
| xds.ClusterLoadAssignmentName( | ||
| types.NamespacedName{Name: service.Weighted.ServiceName, Namespace: service.Weighted.ServiceNamespace}, | ||
| service.Weighted.ServicePort.Name, | ||
| ), | ||
| SocketAddress(service.ExternalName, int(service.Weighted.ServicePort.Port)), | ||
| ) | ||
| if service.Weighted.ServicePort.Port != service.Weighted.HealthPort.Port { | ||
| cla.Endpoints[0].LbEndpoints[0].GetEndpoint().HealthCheckConfig = HealthCheckConfig(service.Weighted.HealthPort.Port) |
There was a problem hiding this comment.
This looks OK to me but I had to stop for a bit when reading - we know we always assign exactly 1 address and therefore it is safe to access Endpoints[0].LbEndpoints[0], right?
There was a problem hiding this comment.
yeah we pass only one address to ClusterLoadAssignment above so the returned cla should have one endpoint entry, but lets add another test of just the ExternalNameClusterLoadAssignment function to endpoint_test.go to be sure
sunjayBhatia
changed the title
sunjayBhatia
added
the
release-note/small
Signed-off-by: yangyang <yang.yang@daocloud.io>
Signed-off-by: yangyang <yang.yang@daocloud.io>
sunjayBhatia
approved these changes
Mar 4, 2024
lubronzhan
pushed a commit
to lubronzhan/contour
that referenced
this pull request
Mar 13, 2024
…rojectcontour#6230) Signed-off-by: yangyang <yang.yang@daocloud.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #6229