provisioner: Use separate flag for each disabled feature #6413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flags on Contour Deployment should be separate, not comma separated list Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
sunjayBhatia
added
kind/bug
sunjayBhatia
requested review from
tsaarni,
skriss,
a team,
rajatvig and
davinci26
and removed request for
a team
sunjayBhatia
added
release-note/none-required
|
oops, accidentally pushed the changelog commit to main 🙃 : ad89ab5 removed changelog tag from this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6413 +/- ##
=======================================
Coverage 81.62% 81.62%
=======================================
Files 133 133
Lines 15856 15857 +1
=======================================
+ Hits 12943 12944 +1
Misses 2619 2619
Partials 294 294
|
skriss
approved these changes
May 6, 2024
SGTM, will do! |
|
Good catch, didn't noticed this flag should be passed separately for each feature. I should add a e2e test to disable multiple features |
SamMHD
pushed a commit
to SamMHD/contour
that referenced
this pull request
Sep 8, 2024
…our#6413) Flags on Contour Deployment should be separate, not comma separated list Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com> Signed-off-by: Saman Mahdanian <saman@mahdanian.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flags on Contour Deployment should be separate, not comma separated list (list causes contour to fail to deploy)