Enable admin route for stats/prometheus
#6503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayton-gonsalves
requested review from
tsaarni and
sunjayBhatia
and removed request for
a team
sunjayBhatia
requested review from
a team,
rajatvig and
izturn
and removed request for
a team
clayton-gonsalves
force-pushed
the
fixup-stats-endpoint
branch
from
19c153c to
aea336b
Compare
clayton-gonsalves
added
the
release-note/small
Signed-off-by: Clayton Gonsalves <clayton.gonsalves@reddit.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6503 +/- ##
=======================================
Coverage 81.63% 81.64%
=======================================
Files 133 133
Lines 15869 15873 +4
=======================================
+ Hits 12955 12959 +4
Misses 2620 2620
Partials 294 294
|
clayton-gonsalves
force-pushed
the
fixup-stats-endpoint
branch
from
aea336b to
64c8646
Compare
tsaarni
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
LGTM! 👍
Just for completeness:
(1) The alternative form GET /stats?format=prometheus for fetching prometheus metrics worked but this change is required for /stats/prometheus.
(2) We intentionally keep blocking GET /stats/recentlookups which was allowed before #6447.
|
Thank you @clayton-gonsalves! |
SamMHD
pushed a commit
to SamMHD/contour
that referenced
this pull request
Sep 8, 2024
Signed-off-by: Clayton Gonsalves <clayton.gonsalves@reddit.com> Signed-off-by: Saman Mahdanian <saman@mahdanian.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the changes made in #6447
the admin endpoint was tightened to only allow
GETrequests with path matches asexact.This change blocked the
stats/prometheusendpoint which is used by prometheus to scrape metrics.Note: If not fixed, this will lead to loss of all prometheus based metrics.