Add circuit breaker support for extension services. #6539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayton-gonsalves
requested review from
skriss and
sunjayBhatia
and removed request for
a team
clayton-gonsalves
added
the
release-note/minor
sunjayBhatia
requested review from
a team,
rajatvig and
davinci26
and removed request for
a team
clayton-gonsalves
force-pushed
the
add-circuit-breakers-for-extension-services
branch
from
2011476 to
85ed13f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6539 +/- ##
==========================================
+ Coverage 81.64% 81.66% +0.02%
==========================================
Files 133 133
Lines 15873 15894 +21
==========================================
+ Hits 12959 12980 +21
Misses 2620 2620
Partials 294 294
|
Signed-off-by: Clayton Gonsalves <clayton.gonsalves@reddit.com>
clayton-gonsalves
force-pushed
the
add-circuit-breakers-for-extension-services
branch
from
85ed13f to
9e946e2
Compare
Signed-off-by: Clayton Gonsalves <clayton.gonsalves@reddit.com>
Signed-off-by: Clayton Gonsalves <clayton.gonsalves@reddit.com>
skriss
requested changes
Jul 22, 2024
There was a problem hiding this comment.
Thanks @clayton-gonsalves, this looks pretty good to me. I just had some nit-picky naming comments to try to keep things consistent/as short as possible. I think we should be able to get this into the upcoming release if you can address remaining feedback
Signed-off-by: Clayton Gonsalves <clayton.gonsalves@reddit.com>
skriss
reviewed
Jul 24, 2024
Signed-off-by: Clayton Gonsalves <clayton.gonsalves@reddit.com>
skriss
approved these changes
Jul 25, 2024
geomacy
pushed a commit
to chaosbox/contour
that referenced
this pull request
Aug 22, 2024
Closes projectcontour#6537. Signed-off-by: Clayton Gonsalves <clayton.gonsalves@reddit.com> Signed-off-by: Geoff Macartney <geoff.macartney@sky.uk>
SamMHD
pushed a commit
to SamMHD/contour
that referenced
this pull request
Sep 8, 2024
Closes projectcontour#6537. Signed-off-by: Clayton Gonsalves <clayton.gonsalves@reddit.com> Signed-off-by: Saman Mahdanian <saman@mahdanian.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for configuring circuit breakers for extension service CRD's.
Fixes #6537
Note to reviewers
The method for configuring circuit breakers differs between extension services and regular services. For extension services, this configuration is managed directly on the extension service CRD rather than through service annotations.
This distinction arises from how Contour creates an Envoy cluster for a given extension service definition. An extension service CRD can be supported by multiple Kubernetes services, but for Envoy, these services are configured within a single Envoy cluster.
Combining annotations from multiple Kubernetes services is complex and can lead to a non-transparent user experience.