accesslog_format added #773
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 23, 2018 18:56
Signed-off-by: Alex Lazarev <itex.lazarev@gmail.com>
|
@turbotankist thank you for your contribution. Can you please take a look at https://github.com/heptio/contour/blob/master/CONTRIBUTING.md#contribution-workflow Specifically
I'd like to close this PR as it cannot be merged as is. I welcome you to continue the discussion on #624 or raise your own issue describing the feature you want added. Once there is a clear decision on how to proceed, feel free to reopen this PR or send a fresh one. Thank you for your time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For request #624
Everybody run contour in kubernetes and all logs need be pased as json