Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

err out bad req #356

Merged
merged 2 commits into from
Jun 26, 2024
Merged

err out bad req #356

merged 2 commits into from
Jun 26, 2024

Conversation

dogancanbakir
Copy link
Member

Closes #350

@dogancanbakir dogancanbakir self-assigned this May 22, 2024
@dogancanbakir
Copy link
Member Author

ignore failing tests; flaky

@Mzack9999 Mzack9999 self-requested a review May 22, 2024 10:18
Mzack9999
Mzack9999 requested changes May 22, 2024
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's update the tests and ensure that the change from nil to error keep things working as expected

@Mzack9999 Mzack9999 linked an issue May 22, 2024 that may be closed by this pull request
The -org option (and not only this one) does not accept Strings #350
Closed
@ehsandeep ehsandeep merged commit 5bc764a into dev Jun 26, 2024
4 checks passed
@ehsandeep ehsandeep deleted the err_out_bad_req branch June 26, 2024 20:30
@BrewTestBot BrewTestBot mentioned this pull request Jun 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mzack9999 Mzack9999 Mzack9999 approved these changes

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees

@dogancanbakir dogancanbakir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The -org option (and not only this one) does not accept Strings
3 participants
@dogancanbakir @ehsandeep @Mzack9999