Skip to content

Conversation

@S0obi
Copy link
Contributor

@S0obi S0obi commented Nov 27, 2022

Description

Add support for Openstack API by creating a new openstack provider.

This first implementation supports username/password authentication with a tenant name. It will display all floating ips defined for all Openstack Instances.

See #258

@ehsandeep ehsandeep linked an issue Dec 10, 2022 that may be closed by this pull request
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@S0obi , resolve merge conflicts and

go mod tidy

@S0obi S0obi force-pushed the feature/support-openstack-provider branch from b5fe8ba to 95378cb Compare December 15, 2022 18:56
@S0obi
Copy link
Contributor Author

S0obi commented Dec 15, 2022

@S0obi , resolve merge conflicts and

go mod tidy

Hey @tarunKoyalwar, I rebased on dev and executed go mod tidy

@tarunKoyalwar
Copy link
Member

Thanks @S0obi , I will approve this once tests are successful

@S0obi S0obi force-pushed the feature/support-openstack-provider branch from 95378cb to 4cce536 Compare December 15, 2022 18:58
@S0obi S0obi force-pushed the feature/support-openstack-provider branch from 4cce536 to 6384975 Compare December 15, 2022 19:13
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@S0obi
Copy link
Contributor Author

S0obi commented Dec 15, 2022

@tarunKoyalwar I justed added missing documentation for tenant_name parameter. Sorry for that :)

@tarunKoyalwar
Copy link
Member

@S0obi , no worries

Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ehsandeep ehsandeep merged commit 8e9bb76 into projectdiscovery:dev Dec 16, 2022
visnetodev pushed a commit to visnetotest/cloudlist that referenced this pull request Dec 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature] Add support for Openstack API

3 participants