Skip to content

Add K8S as provider and GKE in GCP #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ehsandeep merged 18 commits into from
Apr 11, 2023
Merged

Add K8S as provider and GKE in GCP #329

ehsandeep merged 18 commits into from
Apr 11, 2023

Conversation

@ShubhamRasal
Copy link
Contributor

@ShubhamRasal ShubhamRasal commented Apr 6, 2023 •
edited by ehsandeep
Loading

Added new provider -

  • K8s
  • GKE in GCP
  • Update docs

@ShubhamRasal ShubhamRasal self-assigned this Apr 6, 2023
@ShubhamRasal ShubhamRasal marked this pull request as draft April 6, 2023 12:51
@ShubhamRasal ShubhamRasal mentioned this pull request Apr 10, 2023
Closed
@ShubhamRasal ShubhamRasal changed the title Issue 306 add gke Add K8S as provider and GKE in GCP Apr 10, 2023
This was linked to issues Apr 10, 2023
[feature] Add support for GCP GKE #306
Closed
Add kubernetes as Provider #325
Closed
@ShubhamRasal ShubhamRasal linked an issue Apr 10, 2023 that may be closed by this pull request
fix bugs #326
Closed
2 tasks
@ShubhamRasal
Copy link
Contributor Author

ShubhamRasal commented Apr 10, 2023 

❯ ./cloudlist -silent -p kubernetes
10.245.24.190
10.245.67.134
10.245.225.126
10.245.225.89
...

@ShubhamRasal ShubhamRasal marked this pull request as ready for review April 10, 2023 05:47
Mzack9999
Mzack9999 requested changes Apr 10, 2023
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implementation: lgtm - suggesting to remove commented code if not used

ehsandeep
ehsandeep requested changes Apr 11, 2023
View reviewed changes
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint error @ShubhamRasal

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

@ehsandeep ehsandeep merged commit ba8df53 into dev Apr 11, 2023
@ehsandeep ehsandeep deleted the issue-306-add-gke branch April 11, 2023 08:12
visnetodev pushed a commit to visnetotest/cloudlist that referenced this pull request Dec 7, 2025
@ShubhamRasal @ehsandeep
Add K8S as provider and GKE in GCP (projectdiscovery#329)
118f664 
* Add kubernetes provider

- list the service IP clusterIP, externalIPs, LoadBalancer service IP

* Add ingress in k8s provider

* rename provider k8s to kubernetes

* Add gke

* Rename package

* change pkg name

* add makefile, go mod tidy

* Add documenation

* use errorutil, rename gcpauth to auth.go

* Fix the exclude IP

* misc: remove extra lines

* Remove comments

* Upgrade go 14 to 19

* go mod update

* resolve lint erorr

---------

Co-authored-by: Sandeep Singh <sandeep@projectdiscovery.io>
Co-authored-by: sandeep <8293321+ehsandeep@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mzack9999 Mzack9999 Mzack9999 requested changes

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees

@ShubhamRasal ShubhamRasal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix bugs Add kubernetes as Provider [feature] Add support for GCP GKE

4 participants

@ShubhamRasal @ehsandeep @Mzack9999