Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve debugging and use LookPath #18

Merged
merged 5 commits into from
Oct 24, 2024
Merged

Improve debugging and use LookPath #18

merged 5 commits into from
Oct 24, 2024

Conversation

tarunKoyalwar
Copy link
Member

@tarunKoyalwar tarunKoyalwar commented Oct 24, 2024

Proposed Changes

  • Use LookPath for locating and initializing binaries ( it is not intrusive way to validate existance of a command )
  • earlier we used to execute command directly with 1 sec timeout for validating engine which could be the reason behind the flakiness observed in powershell engines and windows env in general
  • Added hooks and extra debug mode to dump combined stdout + stderr
  • upstream PR Code protocol bug fixes and improvements nuclei#5767

Note

Apart from slight intrusive methodology , Nuclei in windows environment was sometimes returning powershell.exe engine not found randomly due to exec behaviour with 1 sec timeout (go in windows is know to be very slow, and this box in particular had less compute) , by switching to LookPath this issue was resolved and template loading time is stable and faster in windows especially with low spec

@ehsandeep ehsandeep merged commit 90c74aa into main Oct 24, 2024
@dogancanbakir dogancanbakir linked an issue Oct 25, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix engine initialization
4 participants