Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix windows path issue #1431

Merged
merged 2 commits into from
Nov 13, 2023
Merged

fix windows path issue #1431

merged 2 commits into from
Nov 13, 2023

Conversation

dogancanbakir
Copy link
Member

Closes #1421.

Note: It still needs to be tested. However, I am setting up a Windows test environment on AWS. I'll make sure to follow up with you once testing is complete.

@dogancanbakir dogancanbakir self-assigned this Nov 6, 2023
@dogancanbakir
Copy link
Member Author

@enomothem,
In the meantime, can you retest with this branch fix_windows_path_issue? Thanks!

@enomothem
Copy link

@dogancanbakir Yes, I did not solve the problem after compiling this branch
image
image

@enomothem
Copy link

I committed a branch that solved the problem, screenshot below 5fd1f84

image

@dogancanbakir
Copy link
Member Author

@enomothem, Made the changes! Thanks for the help!

Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The relative position of the image path does not render properly on html
4 participants