Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove additional -U for apk in Dockerfile #1497

Merged

Conversation

PeterDaveHello
Copy link
Contributor

There is no need to use -U with --no-cache when using apk on Alpine Linux, as using --no-cache will fetch the index every time and leave no local cache, so the index will always be the latest, without temporary files remain in the image.

There is no need to use `-U` with `--no-cache` when using `apk` on
Alpine Linux, as using `--no-cache` will fetch the index every time and leave no local cache, so the index will always be the latest, without temporary files remain in the image.
@Mzack9999 Mzack9999 changed the base branch from main to dev December 27, 2023 20:48
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@Mzack9999 Mzack9999 added Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity. docker Pull requests that update Docker code labels Dec 27, 2023
@Mzack9999 Mzack9999 merged commit 58a3c14 into projectdiscovery:dev Dec 27, 2023
@PeterDaveHello PeterDaveHello deleted the DockerfileImprovement branch December 28, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Pull requests that update Docker code Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants