Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove skipped check #1045

Merged
merged 2 commits into from
Jun 13, 2024
Merged

remove skipped check #1045

merged 2 commits into from
Jun 13, 2024

Conversation

dogancanbakir
Copy link
Member

Closes #1044

see repro steps at #1044

$ go run . -host 183.2.172.185 -pts 2

                  __
  ___  ___  ___ _/ /  __ __
 / _ \/ _ \/ _ \/ _ \/ // /
/_//_/\_,_/\_,_/_.__/\_,_/

                projectdiscovery.io

[INF] Current naabu version 2.3.0 (latest)
[INF] Running CONNECT scan with non root privileges
183.2.172.185:80
183.2.172.185:443
[INF] Skipping 183.2.172.185 [ip], Threshold reached 
[INF] Found 2 ports on host 183.2.172.185 (183.2.172.185)
[INF] Hello

@dogancanbakir dogancanbakir self-assigned this Apr 26, 2024
@dogancanbakir dogancanbakir linked an issue Apr 26, 2024 that may be closed by this pull request
OnResult not be invoked when threshold reached #1044
Closed
Mzack9999
Mzack9999 approved these changes Jun 13, 2024
View reviewed changes
v2/pkg/result/results.go Show resolved Hide resolved
@Mzack9999 Mzack9999 merged commit 3052c2b into dev Jun 13, 2024
9 checks passed
@Mzack9999 Mzack9999 deleted the remove_skipped_check branch June 13, 2024 13:37
@BrewTestBot BrewTestBot mentioned this pull request Oct 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mzack9999 Mzack9999 Mzack9999 approved these changes

@ehsandeep ehsandeep Awaiting requested review from ehsandeep

Assignees

@dogancanbakir dogancanbakir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OnResult not be invoked when threshold reached
2 participants
@dogancanbakir @Mzack9999