Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

making icmp non fatal #1243

Merged
merged 1 commit into from
Oct 21, 2024
Merged

making icmp non fatal #1243

merged 1 commit into from
Oct 21, 2024

Conversation

Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented Oct 21, 2024 •
edited
Loading

Allow naabu to run without requiring the net.ipv4.ping_group_range sysctl setting or CAP_NET_RAW network capabilities

@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Oct 21, 2024
@Mzack9999 Mzack9999 self-assigned this Oct 21, 2024
@Mzack9999 Mzack9999 marked this pull request as ready for review October 21, 2024 12:23
@Mzack9999 Mzack9999 linked an issue Oct 21, 2024 that may be closed by this pull request
ICMP listen should be non fatal #1244
Closed
@ehsandeep ehsandeep merged commit 1716bbf into dev Oct 21, 2024
9 checks passed
@ehsandeep ehsandeep deleted the bugfix-icmp branch October 21, 2024 14:44
@BrewTestBot BrewTestBot mentioned this pull request Oct 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dogancanbakir dogancanbakir dogancanbakir approved these changes

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees

@Mzack9999 Mzack9999

Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ICMP listen should be non fatal
3 participants
@Mzack9999 @ehsandeep @dogancanbakir