Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated deprecated protocol name #77

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Conversation

princechaddha
Copy link
Member

No description provided.

@princechaddha princechaddha self-assigned this Sep 15, 2023
Copy link
Member

@dogancanbakir dogancanbakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@forgedhallpass
Copy link
Collaborator

@princechaddha you have only updated the tests, that is not going to solve the issue.

As @dogancanbakir correctly pointed out, you will have to update the field names, but even that won't be enough, because the new change will break the template normalization function that inserts new lines as separators after specific keys. That's a slightly trickier one to fix.

See:

public static String normalizeTemplate(String yamlTemplate) {

@ehsandeep ehsandeep merged commit df10691 into main Oct 24, 2023
@ehsandeep ehsandeep deleted the updated-deprecated-protocol-name branch October 24, 2023 07:12
@forgedhallpass forgedhallpass linked an issue Nov 14, 2023 that may be closed by this pull request
@forgedhallpass forgedhallpass changed the title updated deprecated protocol name Updated deprecated protocol name Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated requests protocol name with http
4 participants