Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tlsx integration for tls protocol / connection / output #2368

Closed
forgedhallpass opened this issue Jul 29, 2022 · 0 comments · Fixed by #2522
Closed

tlsx integration for tls protocol / connection / output #2368

forgedhallpass opened this issue Jul 29, 2022 · 0 comments · Fixed by #2522
Assignees
Labels
Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Milestone

Comments

@forgedhallpass
Copy link
Contributor

This makes template creation harder, because you would need to look up what constants are supported for such templates, instead of just taking them from the tlsx output. Seamless integration would be preferred.

Example tlsx output:

tlsx -u expired.badssl.com -self-signed -json | jq .

image

Example SSL template:

https://github.com/projectdiscovery/nuclei-templates/blob/9d5f78d24c71944fd7045a5599414e5544a64a9e/ssl/self-signed-ssl.yaml#L28

Nuclei template output:

nuclei -u self-signed.badssl.com:443 -id self-signed-ssl -debug

image

e.g. issuer_cn != issuer_common_name

@forgedhallpass forgedhallpass added Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix Type: Enhancement Most issues will probably ask for additions or changes. labels Jul 29, 2022
@ehsandeep ehsandeep changed the title SSL certification constants in templates do not match the JSON output of tlsx tlsx integration for tls protocol / connection / output Jul 29, 2022
@Ice3man543 Ice3man543 self-assigned this Aug 30, 2022
@Ice3man543 Ice3man543 linked a pull request Aug 30, 2022 that will close this issue
4 tasks
@ehsandeep ehsandeep added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Sep 1, 2022
@ehsandeep ehsandeep added this to the v2.7.8 milestone Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants