-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tlsx integration to nuclei #2522
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't work with deprecated-tls.yaml
(even using -ztls
):
$ echo "expired.badssl.com:443" | go run . -t C:\Users\user\nuclei-templates\ssl\deprecated-tls.yaml -debug
...
[ERR] Could not read nuclei-ignore file: open C:\Users\user\.config\nuclei\.nuclei-ignore: The system cannot find the file specified.
[WRN] Could not parse template C:\Users\user\nuclei-templates\ssl\deprecated-tls.yaml: could not compile request: could not create tlsx service: could not create tls service: invalid min version specified: sslv3
[WRN] Found 1 templates with runtime error (use -validate flag for further examination)
[INF] Using Nuclei Engine 2.7.7 (latest)
[INF] Using Nuclei Templates 9.1.7 (latest)
[FTL] Could not run nuclei: no valid templates were found
@Mzack9999 it works but the mapping name is different. tlsx using ssl30 instead of sslv3. id: deprecated-tls
info:
name: Deprecated TLS Detection (TLS 1.1 or SSLv3)
author: righettod,forgedhallpass
severity: info
reference:
- https://ssl-config.mozilla.org/#config=intermediate
description: |
Both TLS 1.1 and SSLv3 are deprecated in favor of stronger encryption.
remediation: |
Update the web server's TLS configuration to disable TLS 1.1 and SSLv3.
metadata:
shodan-query: ssl.version:sslv2 ssl.version:sslv3 ssl.version:tlsv1 ssl.version:tlsv1.1
tags: ssl
ssl:
- address: "{{Host}}:{{Port}}"
min_version: ssl30
max_version: ssl30
extractors:
- type: json
json:
- " .tls_version" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since ztls
is already supported as part of tlsx, we can enable auto fallback to ztls
here as well and -ztls
flag can still be used for dedicated connection mode, but having auto fallback enabled as default will increase the connection coverage on default run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
id: mismatched-ssl
info:
name: Mismatched SSL Certificate
author: pdteam
severity: low
tags: ssl
ssl:
- address: "{{Host}}:{{Port}}"
matchers:
- type: dsl
dsl:
- "mismatched == true"
echo wrong.host.badssl.com:443 | ./nuclei -t ./ssl/mismatched-ssl.yaml
__ _
____ __ _______/ /__ (_)
/ __ \/ / / / ___/ / _ \/ /
/ / / / /_/ / /__/ / __/ /
/_/ /_/\__,_/\___/_/\___/_/ 2.7.7
projectdiscovery.io
[WRN] Use with caution. You are responsible for your actions.
[WRN] Developers assume no liability and are not responsible for any misuse or damage.
[INF] Using Nuclei Engine 2.7.7 (latest)
[INF] Using Nuclei Templates 9.1.7 (latest)
[INF] Templates added in last update: 45
[INF] Templates loaded for scan: 1
[mismatched-ssl] [ssl] [low] wrong.host.badssl.com
Proposed changes
Closes #2368
Checklist