Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix index out of range error #4998

Merged
merged 1 commit into from
Apr 8, 2024
Merged

fix index out of range error #4998

merged 1 commit into from
Apr 8, 2024

Conversation

tarunKoyalwar
Copy link
Member

@tarunKoyalwar tarunKoyalwar commented Apr 5, 2024 •
edited
Loading

Proposed Changes

  • fixes index out of range error occured due to missing index validations

@tarunKoyalwar tarunKoyalwar self-assigned this Apr 5, 2024
@tarunKoyalwar tarunKoyalwar marked this pull request as ready for review April 5, 2024 18:31
iambouali
iambouali reviewed Apr 8, 2024
View reviewed changes
Copy link

@iambouali iambouali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping solving this! The fix appears to be logically sound with appropriate error handling and boundary checks. I haven't tested it but LGFM

iambouali
iambouali reviewed Apr 8, 2024
View reviewed changes
Copy link

@iambouali iambouali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SCR-20240408-ieqz

The fix looks solid.

@ehsandeep ehsandeep merged commit b86fcb5 into dev Apr 8, 2024
12 checks passed
@ehsandeep ehsandeep deleted the headless-fuzz-panic branch April 8, 2024 08:41
@BrewTestBot BrewTestBot mentioned this pull request Apr 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iambouali iambouali iambouali left review comments

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees

@tarunKoyalwar tarunKoyalwar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tarunKoyalwar @ehsandeep @iambouali