Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: skip-variables-check option in self-contained templates #5053

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Fix: skip-variables-check option in self-contained templates #5053

merged 3 commits into from
Apr 23, 2024

Conversation

RamanaReddy0M
Copy link
Contributor

@RamanaReddy0M RamanaReddy0M commented Apr 15, 2024 •
edited
Loading

Proposed changes

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@RamanaReddy0M RamanaReddy0M self-assigned this Apr 15, 2024
@RamanaReddy0M RamanaReddy0M linked an issue Apr 15, 2024 that may be closed by this pull request
skip-variables-check option not working in self-contained templates #5026
Closed
tarunKoyalwar
tarunKoyalwar approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

@ehsandeep ehsandeep merged commit 61e9be5 into dev Apr 23, 2024
9 of 12 checks passed
@ehsandeep ehsandeep deleted the issue-5026-fix-skip-variables-check branch April 23, 2024 10:34
@BrewTestBot BrewTestBot mentioned this pull request Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarunKoyalwar tarunKoyalwar tarunKoyalwar approved these changes

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees

@RamanaReddy0M RamanaReddy0M

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

skip-variables-check option not working in self-contained templates
3 participants
@RamanaReddy0M @ehsandeep @tarunKoyalwar