-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat 5059 #5060
Merged
Merged
Feat 5059 #5060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks so much for your contribution @scottdharvey , we really appreciate it! |
dogancanbakir
requested changes
Apr 17, 2024
dogancanbakir
approved these changes
Apr 22, 2024
tarunKoyalwar
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm ! there shouldn't be any breaking changes for sdk users, since we are only using catalog interface instead of disk catalog struct
ehsandeep
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Currently,
protocols.ExecutorOptions.Catalog
usescatalog.Catalog
whilelib.NucleiEngine.Catalog
uses*disk.DiskCatalog
. However,disk.DiskCatalog
satisfies thecatalog.Catalog
interface by design.changes:
lib.NucleiEngine.Catalog
tocatalog.Catalog
lib.NucleiSDKOptions
functionUseSuppliedCatalog(cat catalog.Catalog)
which assigns the supplied catalog toNucleiEngine.catalog
NucleiEngine.init()
to use the defaultdisk.DiskCatalog
whenNucleiEngine.catalog
is nil (not assigned by UseSuppliedCatalog`)#5059
Checklist