Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with -ms option to scan non accessible host #5576

Merged
merged 16 commits into from
Aug 28, 2024

Conversation

dogancanbakir
Copy link
Member

@dogancanbakir dogancanbakir commented Aug 26, 2024

Proposed changes

Closes #5556

This PR triggers a failed event if the OnResult callback is not called, but it does not capture the "exact" error described in the issue's expected behavior section.

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

$ ./nuclei -u https://trust_me_bro.real -id tech-detect -matcher-status                                                1 ↵ tarun@Taruns-MacBook-Pro

                     __     _
   ____  __  _______/ /__  (_)
  / __ \/ / / / ___/ / _ \/ /
 / / / / /_/ / /__/ /  __/ /
/_/ /_/\__,_/\___/_/\___/_/   v3.3.1

		projectdiscovery.io

[INF] Current nuclei version: v3.3.1 (latest)
[INF] Current nuclei-templates version: v9.9.3 (latest)
[WRN] Scan results upload to cloud is disabled.
[INF] New templates added in latest release: 56
[INF] Templates loaded for current scan: 1
[INF] Executing 1 signed templates from projectdiscovery/nuclei-templates
[INF] Targets loaded for current scan: 1
[tech-detect] [failed] [http] [info] https://trust_me_bro.real
[INF] No results found. Better luck next time!

Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add test covering -ms options against non accessible host running template 4-5 templates of each protocol type ensuring they are returning results + error information.

@ehsandeep ehsandeep changed the title fail if OnResult callback is not called Fixed issue with -ms option to scan non accessible host Aug 28, 2024
@ehsandeep ehsandeep merged commit 6b71af4 into dev Aug 28, 2024
10 of 12 checks passed
@ehsandeep ehsandeep deleted the fail_if_callback_not_called branch August 28, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Missing failed event for non accessible host
3 participants