Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: do not use backticks #5687

Merged
merged 1 commit into from
Oct 4, 2024
Merged

style: do not use backticks #5687

merged 1 commit into from
Oct 4, 2024

Conversation

vil02
Copy link
Contributor

@vil02 vil02 commented Oct 4, 2024

Proposed changes

Fixes #5684.

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vil02 vil02 marked this pull request as ready for review October 4, 2024 10:39
dwisiswant0
dwisiswant0 approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@dwisiswant0 dwisiswant0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @vil02! Merging it now.

@dwisiswant0 dwisiswant0 merged commit 23825c7 into projectdiscovery:dev Oct 4, 2024
1 check passed
@vil02 vil02 deleted the 5684-bug-do-not-use-backticks-in-shell-files branch October 4, 2024 21:19
@BrewTestBot BrewTestBot mentioned this pull request Oct 19, 2024
Merged
@blsaccess blsaccess mentioned this pull request Oct 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwisiswant0 dwisiswant0 dwisiswant0 approved these changes

@dogancanbakir dogancanbakir Awaiting requested review from dogancanbakir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Do not use backticks in shell files
2 participants
@vil02 @dwisiswant0