Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolver stats #171

Closed
wants to merge 1 commit into from
Closed

resolver stats #171

wants to merge 1 commit into from

Conversation

ravlio
Copy link

@ravlio ravlio commented Oct 20, 2023

collect performance stats of resolvers

@Mzack9999 Mzack9999 linked an issue Nov 30, 2023 that may be closed by this pull request
@Mzack9999 Mzack9999 self-requested a review November 30, 2023 20:05
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor lint errors

@ravlio ravlio marked this pull request as draft December 1, 2023 11:50
@ravlio
Copy link
Author

ravlio commented Dec 1, 2023

converted to draft

@calab33p
Copy link

Hi @ravlio , @Mzack9999 , what is the status of this? Is it just lint errors? Happy to jump in and help get this pushed if that would help. I could use this functionality as well.

@calab33p
Copy link

I also think we could use an error type for possible net.OpError's . I have seen i/o timeouts and conn refused on read.

@ravlio
Copy link
Author

ravlio commented Aug 30, 2024

@calab33p hi. I think this PR is obsolete. The idea was to make heuristic proxy probing based on stats to determine the fastest ones. I'll close it

@ravlio ravlio closed this Aug 30, 2024
@calab33p
Copy link

@ravlio It's functionality I would find helpful to date. The list of resolvers I'm getting from dnsvalidator.py aren't the best and having some heuristics around which resolvers are good and which ones aren't is something I would find helpful. Is there a reason you think it is obsolete now? Is there something I am missing?

@ehsandeep ehsandeep deleted the stats branch August 31, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add internal stats
3 participants