Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

panic: runtime error: invalid memory address or nil pointer dereference #127

Closed
ehsandeep opened this issue Nov 29, 2022 · 0 comments · Fixed by #132
Closed

panic: runtime error: invalid memory address or nil pointer dereference #127

ehsandeep opened this issue Nov 29, 2022 · 0 comments · Fixed by #132
Assignees
@tarunKoyalwar
Labels
Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Milestone
v1.0.0

Comments

@ehsandeep
Copy link
Member

tlsx version:

main/dev

Current Behavior:

echo 12.35.70.0/23 | ./tlsx -silent
12.35.70.76:443
12.35.70.74:443
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x660 pc=0x1016a48cc]

goroutine 234 [running]:
github.com/zmap/zcrypto/verifier.CheckOCSP({0x101fcfa90, 0x140001a6050}, 0x0, 0x1400134e300?)
	/Users/geekboy/go/pkg/mod/github.com/zmap/zcrypto@v0.0.0-20220803033029-557f3e4940be/verifier/revocation.go:30 +0x2c
github.com/projectdiscovery/tlsx/pkg/tlsx/clients.IsZTLSRevoked(0x0)
	/Users/geekboy/Github/tlsx/pkg/tlsx/clients/clients.go:324 +0x3c
github.com/projectdiscovery/tlsx/pkg/tlsx/clients.IsTLSRevoked(0x14001028900?)
	/Users/geekboy/Github/tlsx/pkg/tlsx/clients/clients.go:319 +0x30
github.com/projectdiscovery/tlsx/pkg/tlsx/tls.(*Client).convertCertificateToResponse(0x1400024a918, {0x14001028900, 0xb}, 0x1400168c000)
	/Users/geekboy/Github/tlsx/pkg/tlsx/tls/tls.go:206 +0x158
github.com/projectdiscovery/tlsx/pkg/tlsx/tls.(*Client).ConnectWithOptions(0x1400024a918, {0x14001028900, 0xb}, {0x0, 0x0}, {0x101767745, 0x3}, {{0x0, 0x0}, {0x0, ...}, ...})
	/Users/geekboy/Github/tlsx/pkg/tlsx/tls/tls.go:186 +0x734
github.com/projectdiscovery/tlsx/pkg/tlsx/auto.(*Client).ConnectWithOptions(0x1400024a948, {0x14001028900, 0xb}, {0x0, 0x0}, {0x101767745, 0x3}, {{0x0, 0x0}, {0x0, ...}, ...})
	/Users/geekboy/Github/tlsx/pkg/tlsx/auto/auto.go:38 +0x88
github.com/projectdiscovery/tlsx/pkg/tlsx.(*Service).ConnectWithOptions(0x1400024a900, {0x14001028900, 0xb}, {0x0, 0x0}, {0x101767745, 0x3}, {{0x0, 0x0}, {0x0, ...}, ...})
	/Users/geekboy/Github/tlsx/pkg/tlsx/tlsx.go:58 +0xe0
github.com/projectdiscovery/tlsx/internal/runner.(*Runner).processInputElementWorker(0x1400043de40, 0x0?, 0x0?)
	/Users/geekboy/Github/tlsx/internal/runner/runner.go:161 +0x528
created by github.com/projectdiscovery/tlsx/internal/runner.(*Runner).Execute
	/Users/geekboy/Github/tlsx/internal/runner/runner.go:122 +0x58

Expected Behavior:

no crash
@ehsandeep ehsandeep added Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. Priority: High After critical issues are fixed, these should be dealt with before any further issues. labels Nov 29, 2022
@ehsandeep ehsandeep added this to the v1.0.0 milestone Nov 29, 2022
@tarunKoyalwar tarunKoyalwar mentioned this issue Dec 5, 2022
Merged
@ehsandeep ehsandeep added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Dec 8, 2022
@tarunKoyalwar tarunKoyalwar mentioned this issue Dec 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tarunKoyalwar tarunKoyalwar

Labels
Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

fix resolved ip and other minor improvements projectdiscovery/tlsx
2 participants
@ehsandeep @tarunKoyalwar