Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix resolved ip and other minor improvements #132

Merged
merged 3 commits into from
Dec 8, 2022
Merged

fix resolved ip and other minor improvements #132

merged 3 commits into from
Dec 8, 2022

Conversation

tarunKoyalwar
Copy link
Member

Description

  1. Fix resolvedIP to always return IP .
  2. Added Unit Test TestResolvedIP to prevent future errors.
  3. Added a default dialer .
  4. Fix Nil pointer error in IsZTLSRevoked . returns true if cert is nil

closes #131
closes #127

@tarunKoyalwar tarunKoyalwar changed the base branch from main to dev December 5, 2022 19:31
@tarunKoyalwar
Copy link
Member Author

resolves projectdiscovery/nuclei#2966

@tarunKoyalwar tarunKoyalwar linked an issue Dec 5, 2022 that may be closed by this pull request
JSON output field include host information in the ip field for SSL Templates projectdiscovery/nuclei#2966
Closed
@tarunKoyalwar tarunKoyalwar removed the request for review from ehsandeep December 5, 2022 19:39
@tarunKoyalwar tarunKoyalwar marked this pull request as draft December 5, 2022 19:39
@Mzack9999
Copy link
Member

Mzack9999 commented Dec 6, 2022 •
edited
Loading

lgtm - todo:

  • Update branch from dev
  • Failing tests

@Mzack9999 Mzack9999 added the Type: Enhancement Most issues will probably ask for additions or changes. label Dec 8, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 8, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

22.2% 22.2% Coverage
4.4% 4.4% Duplication

@ehsandeep ehsandeep marked this pull request as ready for review December 8, 2022 05:37
@ehsandeep ehsandeep merged commit 6392910 into dev Dec 8, 2022
@ehsandeep ehsandeep deleted the issue-131-resolvedIp branch December 8, 2022 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mzack9999 Mzack9999 Mzack9999 approved these changes

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees

@tarunKoyalwar tarunKoyalwar

Labels
Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
No milestone
3 participants
@tarunKoyalwar @Mzack9999 @ehsandeep