Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolvedIP does not return ip address when hostname is used #131

Closed
tarunKoyalwar opened this issue Dec 5, 2022 · 1 comment · Fixed by #132
Closed

resolvedIP does not return ip address when hostname is used #131

tarunKoyalwar opened this issue Dec 5, 2022 · 1 comment · Fixed by #132
Assignees
@tarunKoyalwar
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Milestone
v1.0.0

Comments

@tarunKoyalwar
Copy link
Member

tlsx version:

main | dev

Current Behaviour:

when using ConnectWithOptions with hostname hackerone.com , resolvedIP does not return ip instead returns hostname itself .

Expected Behaviour:

Whatever the input type is hostname or ip resolvedIP should always return IP address of connection

Remediation

Ip address of hostname can be obtained using rawConn.RemoteAddr().String()
@tarunKoyalwar tarunKoyalwar added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Dec 5, 2022
@tarunKoyalwar
Copy link
Member Author

Will close projectdiscovery/nuclei#2966

@tarunKoyalwar tarunKoyalwar self-assigned this Dec 5, 2022
@tarunKoyalwar tarunKoyalwar mentioned this issue Dec 5, 2022
Merged
@ehsandeep ehsandeep added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Dec 8, 2022
@ehsandeep ehsandeep added this to the v1.0.0 milestone Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tarunKoyalwar tarunKoyalwar

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

fix resolved ip and other minor improvements projectdiscovery/tlsx
2 participants
@ehsandeep @tarunKoyalwar