-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix false positive with untrusted flag #296
Conversation
✗ ./tlsx -un -host ebay.co.jp,comicon.it,sambonet.it
_____ _ _____ __
|_ _| | / __\ \/ /
| | | |__\__ \> <
|_| |____|___/_/\_\ v1.1.0
projectdiscovery.io
[INF] Current tlsx version v1.1.0 (latest)
sambonet.it:443
ebay.co.jp:443
comicon.it:443
[INF] Connections made using crypto/tls: 3, zcrypto/tls: 0, openssl: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - I suggest moving the update certificate logic to a separate cmd utility (e.g., https://github.com/projectdiscovery/wappalyzergo/blob/main/cmd/update-fingerprints/main.go) that is run with a cron-fashion. Then it just gets loaded via embed, removing the need of reading/writing any external file as it gets included directly in the final binary:
import (
_ "embed"
)
//go:embed root_certs.pem
var data string
What do you think?
add gh action to update assets/root-certs file weekly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
$ go run . -un -host ebay.co.jp,comicon.it,sambonet.it
...
sambonet.it:443
comicon.it:443
ebay.co.jp:443
[INF] Connections made using crypto/tls: 3, zcrypto/tls: 0, openssl: 0
#268 False positive with untrusted flag, but manual certificate check shows trusted status