Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AS input support #96

Merged
merged 8 commits into from
Oct 17, 2022
Merged

Add AS input support #96

merged 8 commits into from
Oct 17, 2022

Conversation

ShubhamRasal
Copy link
Contributor

@ShubhamRasal
Add AS input support #36
728b751 
- Add mapcidr integration for asn support
- Check if the input is ASN, use GetIPAddressesAsStream() func to get IP
  address for that ASN.
@ShubhamRasal ShubhamRasal self-assigned this Oct 13, 2022
@ShubhamRasal ShubhamRasal added the Status: In Progress This issue is being worked on, and has someone assigned. label Oct 13, 2022
@ehsandeep ehsandeep linked an issue Oct 13, 2022 that may be closed by this pull request
Add support for AS identifiers #36
Closed
@ShubhamRasal ShubhamRasal marked this pull request as draft October 13, 2022 10:29
@ShubhamRasal ShubhamRasal marked this pull request as ready for review October 14, 2022 03:20
Mzack9999
Mzack9999 previously requested changes Oct 14, 2022
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - few empty lines to remove

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

73.5% 73.5% Coverage
0.0% 0.0% Duplication

@Mzack9999 Mzack9999 dismissed their stale review October 17, 2022 08:01

requested new review

@Mzack9999 Mzack9999 added Type: Enhancement Most issues will probably ask for additions or changes. and removed Status: In Progress This issue is being worked on, and has someone assigned. labels Oct 17, 2022
ehsandeep
ehsandeep approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

echo AS1449 | ./tlsx -san -cn -silent

43.230.180.230:443 [zscalerthree.net]
43.230.180.230:443 [gateway.zscalerthree.net]
43.230.180.228:443 [zscalerthree.net]
43.230.180.228:443 [gateway.zscalerthree.net]
43.230.180.237:443 [zscalerthree.net]
43.230.180.237:443 [gateway.zscalerthree.net]
43.230.180.129:443 [nova-phx.paypalcorp.com]
43.230.180.129:443 [nova-fra.paypalcorp.com]
43.230.180.129:443 [nova-pvg.paypalcorp.com]
43.230.180.129:443 [nova-pvg.paypalcorp.com.cn]
43.230.180.129:443 [nova-fra.g.paypalcorp.com]
43.230.180.129:443 [nova-kul.paypalcorp.com]
43.230.180.129:443 [nova-ash.paypalcorp.com]
43.230.180.129:443 [nova-dub.g.paypalcorp.com]
43.230.180.129:443 [nova.paypalcorp.com]
43.230.180.129:443 [nova-glb.paypalcorp.com]
43.230.180.129:443 [nova.g.paypalcorp.com]
43.230.180.129:443 [nova-pvg.g.paypalcorp.com.cn]
43.230.180.129:443 [nova-emea.g.paypalcorp.com]
43.230.180.129:443 [nova-phx.g.paypalcorp.com]
43.230.180.129:443 [nova-ams.paypalcorp.com]
43.230.180.129:443 [nova-dev.paypalcorp.com]
43.230.180.129:443 [nova-apac.g.paypalcorp.com]
43.230.180.129:443 [nova-pvg.g.paypalcorp.com]
43.230.180.129:443 [nova-lvs.g.paypalcorp.com]
43.230.180.129:443 [nova-luo.paypalcorp.com]
43.230.180.129:443 [nova-syd.paypalcorp.com]
43.230.180.129:443 [nova-sin.paypalcorp.com]
43.230.180.129:443 [nova-sin.g.paypalcorp.com]
43.230.180.129:443 [nova-dub.paypalcorp.com]
43.230.180.129:443 [nova-lab.paypalcorp.com]
43.230.180.129:443 [nova-ash.g.paypalcorp.com]
43.230.180.129:443 [nova-lvs.paypalcorp.com]
43.230.180.129:443 [nova-maa.paypalcorp.com]
43.230.180.129:443 [nova-pvg.paypalcorp.cn]
43.230.180.129:443 [nova-gtm.paypalcorp.com]
43.230.180.129:443 [nova-maa.g.paypalcorp.com]
43.230.180.238:443 [zscalerthree.net]
43.230.180.238:443 [gateway.zscalerthree.net]
43.230.180.229:443 [zscalerthree.net]
43.230.180.229:443 [gateway.zscalerthree.net]
43.230.180.240:443 [zscalerthree.net]
43.230.180.240:443 [gateway.zscalerthree.net]
173.224.160.8:443 [lvs-hdx-lab.paypalcorp.com]
173.224.160.8:443 [vs-ogr.paypalcorp.com]
43.230.180.138:443 [nova-syd.paypalcorp.com]
43.230.180.138:443 [nova-sin.paypalcorp.com]
43.230.180.138:443 [nova-dub.paypalcorp.com]
43.230.180.138:443 [nova-pvg.g.paypalcorp.com]
43.230.180.138:443 [nova-sin.g.paypalcorp.com]
43.230.180.138:443 [nova-pvg.paypalcorp.com.cn]
43.230.180.138:443 [nova-pvg.g.paypalcorp.com.cn]
43.230.180.138:443 [nova.g.paypalcorp.com]
....

@ehsandeep ehsandeep merged commit 9500236 into dev Oct 17, 2022
@ehsandeep ehsandeep deleted the issue-36-add-asn-input-support branch October 17, 2022 08:09
@ehsandeep ehsandeep mentioned this pull request Oct 17, 2022
Closed
@ehsandeep ehsandeep restored the issue-36-add-asn-input-support branch October 18, 2022 09:35
@ehsandeep ehsandeep deleted the issue-36-add-asn-input-support branch October 18, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@ShubhamRasal ShubhamRasal

Labels
Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for AS identifiers
3 participants
@ShubhamRasal @ehsandeep @Mzack9999