remove useless engine check #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMGS
reviewed
Jan 2, 2024
engine/factory/factory.go
Outdated
| } | ||
|
|
||
| // NewEngineCache . | ||
| func NewEngineCache(config types.Config) *EngineCache { | ||
| func NewEngineCache(config types.Config, sto store.Store) *EngineCache { |
CMGS
reviewed
Jan 2, 2024
engine/factory/factory.go
Outdated
Comment on lines
96
to
103
| if _, err := e.sto.GetNodeStatus(ctx, nodename); err != nil && errors.Is(err, types.ErrInvaildCount) { | ||
| logger.Warnf(ctx, "node %s is offline, the cache will be removed", nodename) | ||
| RemoveEngineFromCache(ctx, params.endpoint, params.ca, params.cert, params.key) | ||
| } else { | ||
| logger.Errorf(ctx, err, "engine %+v is unavailable, will be replaced and removed", cacheKey) | ||
| e.cache.Set(cacheKey, &fake.EngineWithErr{DefaultErr: err}) | ||
| } | ||
| } |
There was a problem hiding this comment.
if _, err := e.sto.GetNodeStatus(ctx, nodename); err != nil && errors.Is(err, types.ErrInvaildCount) {
logger.Warnf(ctx, "node %s is offline, the cache will be removed", nodename)
RemoveEngineFromCache(ctx, params.endpoint, params.ca, params.cert, params.key)
return
}
logger.Errorf(ctx, err, "engine %+v is unavailable, will be replaced and removed", cacheKey)
e.cache.Set(cacheKey, &fake.EngineWithErr{DefaultErr: err})
There was a problem hiding this comment.
还有另外一个小细节是我习惯把 internal 函数后置，放最后……
There was a problem hiding this comment.
okay，这里的逻辑其实有点乱，我发现其实现在很多地方隐藏了一个node一个engine的假设，那么确实是这样，代码可以大幅简化，我都怀疑这个checkAlive还有没有用
There was a problem hiding this comment.
本来我是想把engine cache相关的代码从store拆出来的，总觉得这两个搅合到一起不好，但是拆一半拆不动了回滚了，所以给那个metrics调用的接口加了个option，免得一个node挂了，结果因为metrics的定期调用还傻傻的check alive，弄一堆错误日志
CMGS
reviewed
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.