Add implementation of likely subtags #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes projectfluent#9 and partly fixes projectfluent#10 but has test failures when the `likely-subtags` feature is enabled, as discussed in projectfluent#10. This implementation follows the Unicode recommendataions fairly closely but does not implement deprecated or grandfathered mappings.
|
Great, thank you! I'm going to review it next week - is that ok? |
|
Yes, it's fine, I can continue with this locally patched. More important to get this right than to get it in quickly :) Another point while I'm at it. It's possible to replace the binary search lookups with minimal perfect hashes as in unicode-rs/unicode-normalization#37 . I have a feeling the speed improvement is not worth the extra maintenance complexity, but let me know. |
|
@raphlinus - can we move this to |
|
Same as the other PR, sure. |
|
I started working on that in unic-locale - https://github.com/zbraniecki/unic-locale/pull/15/files For now the implementation is very naive and slow, but should be fairly complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9 and partly fixes #10 but has test failures when the
likely-subtagsfeature is enabled, as discussed in #10.This implementation follows the Unicode recommendataions fairly
closely but does not implement deprecated or grandfathered mappings.