-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make list of supported browsers be the list of supported browsers #133
Comments
According to https://caniuse.com/usage-table there aren't many browser versions above 1% market share. For instance, only Firefox 57 meets the criteria and I doubt we need any transpilation at all to ensure compatibility with it. Maybe there's something more forgiving than How about |
@zbraniecki, @mathjazz, @adngdb — do you have an opinion about this? What's the best reasonable set of browser versions that would also make sense for Pontoon? |
I'm against linking our support range to React's. I believe we should support evergreens. Period. We're a 0.5 library, by 1.0 we hopefully will only have evergreens on the market, and if we need to support a single outlier (IE11) - then let's weight the cost/reward for it individually. Supporting Safari 9.1 is completely out of scope and the cost seems disproportional to any potential value to me. |
Pontoon's primary target audience is Mozilla, so I don't have a strong opinion on this. |
OK, how about this then: |
Chrome for Android release version is 64. I'm just not impressed by the data, and it feels wonky that we're trying to be driven by that data. |
IE10 - released on September 4, 2012... I question the applicability of this data onto our customer or potential customer population. Major web assets don't support IE10 and IE11. We're a pre-1.0 modern client side library. Major apps like ZenDesk stopped supporting IE10 in 2016. Secondly, I question the data source. StatCounter is notoriously listed as the very worst data source for browsers marketshare. I'd prefer not to sink us into supporting esoteric browsers because StatCounter overrepresents them. In short - as since the beginning of Fluent project I believe we should only support evergreens and IE11, and I'd like us to stop supporting IE11 asap. Salesforce stopped supporting IE11 in December 2017 [0]. I believe we can expect IE11 to not be supported by many major players by the time we release Fluent 1.0 and I'd like us to consider dropping it then. |
Our conversations about updates in Firefox for fluent have demonstrated that we shouldn't build too many arguments on our version number, and make too strong assumptions on when we'll actually have to declare 1.0. I don't see IE11 being on a strong decline. |
5 months later, this has become a pressing issue. We're using async generator functions in Gecko's I'd like to drop IE support ASAP. I reached out to Common Voice, Test Pilot and Screenshots to ask what their browser support matrix was. Common Voice explicitly doesn't support IE. I tested Test Pilot and it doesn't work in IE 11; I don't know yet if that's intended. Screenshots works in IE and I'm waiting for their reply. Transpilation for compatibility can be thought of as a layered process and can roughly be represented as the following 4 stages:
By dropping IE, we can focus on browsers which support sync generators (browerslist):
We can also go further and require browers which support async functions (browserslist):
This would help reduce the size of |
Interesting localization problem: From https://www.udacity.com/tech-requirements:
From https://de.udacity.com/technische-voraussetzungen:
Errr. @hkasemir ? |
I really hope this is an outdated translation :) |
I'd be incredibly happy to drop IE11. Looking at https://caniuse.com/#search=async it seems like we should be able to set the bar on "async functions" and I'd like us to do that. |
hmm, I don't speak German, but I'll ask our website team about it |
An update on the browser support of Mozilla websites which use Fluent:
|
@hkasemir Would dropping IE11 and requiring the following browser versions work for Udacity?
|
hey! I think that would be fine :) I brought up the mismatched translations with our marketing dev team, and they are working on updating our localized sites to match the US one. Based on that, I think we should be safe with that list of browsers. |
A correction to the list of browsers above. It looks like async functions shipped in iOS Safari 10.3. For clarity, I've also removed the Android versions of Firefox and Chrome, which ship with the same JS features support as their desktop counterparts.
|
I've been keeping track of my communications with projects using Fluent in #133 (comment). Today I was able to confirm the last project on the list. Here's the complete list again:
I'm going to open a PR to change the browser support matrix for all
Thanks to everyone for taking part in this discussion! |
Right now, we're claiming to support:
fluent.js/compat_config.js
Lines 16 to 21 in 0b8ba5f
The option about market share is completely useless, per the algorithm, this is the last 4 versions of any browser, or a Firefox ESR, but not old IEs.
If we wanted to reduce the list of supported browsers according to market share, it'd need to be a
but that excludes any version of Firefox or IE that by itself doesn't have that market share, including ESR, http://browserl.ist/?q=last+4+versions%2C+Firefox+ESR%2C+not+ie+%3C+9%2C+not+%3C1%25.
My suspicion is that our list was intended to be "of all the browsers with at least 1% market share, support the last 4 versions, IE aside". Such a query doesn't exist, sadly.
The only way we could emulate that is to manually maintain the list of browsers we support, and then restrict to the last 4 versions, or so.
The text was updated successfully, but these errors were encountered: