Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the cached-iterable dependency #260

Merged
merged 1 commit into from
Jul 24, 2018
Merged

Add the cached-iterable dependency #260

merged 1 commit into from
Jul 24, 2018

Conversation

stasm
Copy link
Contributor

@stasm stasm commented Jul 19, 2018 •
edited
Loading

In #212 I suggested to move CachedIterable out of the fluent package. To this end, I have created cached-iterable. This PR makes fluent, fluent-dom and fluent-react use it.

@stasm
Copy link
Contributor Author

stasm commented Jul 19, 2018

@zbraniecki Can you advise how to make fluent-gecko work with cached-iterable? Should it be inlined into Localization.jsm and DOMLocalization.jsm? Or rather, exported by its own module file, CachedIterable.jsm?

@zbraniecki
Copy link
Collaborator

It will likely be imported into Localization.jsm. I'd prefer to avoid having to use a new jsm for this.

@stasm
Copy link
Contributor Author

stasm commented Jul 24, 2018

Thanks, I'll make the necessary changes to fluent-gecko.

@stasm stasm merged commit 3e05317 into projectfluent:master Jul 24, 2018
@stasm stasm deleted the cached-iterable-dep branch July 24, 2018 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stasm @zbraniecki