Skip to content

.equals should not ignore Variant and Attribute order, fixes #111 #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2019
Merged

.equals should not ignore Variant and Attribute order, fixes #111 #112

merged 1 commit into from
Mar 25, 2019

Conversation

Pike
Copy link
Contributor

@Pike Pike commented Mar 13, 2019

This goes back to the conversation in projectfluent/fluent.js#172

@spookylukey
Copy link
Collaborator

LGTM

@Pike Pike force-pushed the node.equals.order branch from 7c647df to 6b38ad0 Compare March 19, 2019 15:21
@Pike
Copy link
Contributor Author

Pike commented Mar 19, 2019

I removed the sorting_key here, in line with projectfluent/fluent.js#172 (comment).

@stasm stasm merged commit 9673bf1 into projectfluent:master Mar 25, 2019
@Pike Pike deleted the node.equals.order branch April 3, 2019 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pike @spookylukey @stasm