metadata.json: remove "version" field #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "version" field in the extension meta data is reserved for internal use on extensions.gnome.org. If at all, the version should be set to a value that can be used as an argument to python's int() function, which is not the case for the string we currently use. The general recommendation is not to use "version" in metadata.json. See e.g. https://gitlab.gnome.org/Infrastructure/extensions-web/issues/102#note_740134
matthijskooijman
approved these changes
Mar 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete the "version" field from
metadata.json. This is the result of discussions on #321, #323, #324, and extensions-web #102, extensions-web #95.In order to not have to do this on every branch later, we should merge this PR before merging any "GNOME 3.3x support" PRs (#299, #312, #316, #323), even if it means that I need to rebase my PRs again.
@matthijskooijman, again, I couldn't invite you for review.