Skip to content

Commit

Permalink
feat: add commands resume and continue
Browse files Browse the repository at this point in the history
Support resuming/continuing the last tracked activity.

When `hamster resume` is called, the last tracked activity is
started, i.e., the same activity is started again with the current
start_time.

If `hamster continue` (or, for convience, hamster resume `--no-gaps`)
is called, the last tracked activity continues to be tracked, i.e.,
its end_time is removed and there are no gaps in the time tracking.

Signed-off-by: Olaf Lessenich <olessenich@eclipsesource.com>
  • Loading branch information
xai committed Nov 28, 2023
1 parent 9eb80bc commit ea53132
Show file tree
Hide file tree
Showing 5 changed files with 46 additions and 2 deletions.
18 changes: 17 additions & 1 deletion src/hamster-cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,16 @@ def start(self, *args):
return id_


def resume(self, *args, no_gap=False):
'''Resume the last activity.'''
facts = self.storage.get_todays_facts()
if facts and facts[-1].end_time:
no_gap = no_gap or "--no-gap" in args
self.storage.resume_tracking(no_gap)
else:
print((_("No activity to resume")))


def stop(self, *args):
'''Stop tracking the current activity.'''
self.storage.stop_tracking()
Expand Down Expand Up @@ -419,6 +429,8 @@ def version(self):
Actions:
* add [activity [start-time [end-time]]]: Add an activity
* stop: Stop tracking current activity.
* resume: The last tracked activity is tracked again from now
* continue: The last tracked activity is continued without a gap since its last end time
* list [start-date [end-date]]: List activities
* search [terms] [start-date [end-date]]: List activities matching a search
term
Expand Down Expand Up @@ -488,13 +500,17 @@ def version(self):
else:
action = args.action

if action in ("about", "add", "edit", "overview", "preferences"):
if action in ("about", "add", "edit", "overview", "preferences", "continue"):
if action == "add" and args.action_args:
assert not unknown_args, "unknown options: {}".format(unknown_args)
# directly add fact from arguments
id_ = hamster_client.start(*args.action_args)
assert id_ > 0, "failed to add fact"
sys.exit(0)
elif action == "continue":
assert not unknown_args, "unknown options: {}".format(unknown_args)
hamster_client.resume(*args.action_args, no_gap=True)
sys.exit(0)
else:
app.register()
if action == "edit":
Expand Down
8 changes: 8 additions & 0 deletions src/hamster-service.py
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,14 @@ def StopTracking(self, end_time):
end_time = dt.datetime.utcfromtimestamp(end_time)
return self.stop_tracking(end_time)

@dbus.service.method("org.gnome.Hamster")
def ResumeTracking(self, no_gap = False):
"""Resumes tracking the last activity.
Parameters:
b no_gap: Use the previous end time as start time to fill the untracked gap.
Default is False.
"""
return self.resume_tracking(no_gap)

@dbus.service.method("org.gnome.Hamster")
def StopOrRestartTracking(self):
Expand Down
2 changes: 1 addition & 1 deletion src/hamster.bash
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ _hamster()
#
# The basic options we'll complete.
#
opts="activities categories current export list search start stop "
opts="activities categories current export list search start stop resume continue "


#
Expand Down
8 changes: 8 additions & 0 deletions src/hamster/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,14 @@ def add_fact(self, fact, temporary_activity = False):

return new_id

def resume_tracking(self, no_gap = False):
"""Resume tracking last activity.
Parameters:
b no_gap: Use the previous end time as start time to fill the untracked gap.
Default is False.
"""
return self.conn.ResumeTracking(no_gap)

def stop_tracking(self, end_time = None):
"""Stop tracking current activity. end_time can be passed in if the
activity should have other end time than the current moment"""
Expand Down
12 changes: 12 additions & 0 deletions src/hamster/storage/storage.py
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,18 @@ def stop_tracking(self, end_time):
self.__touch_fact(facts[-1], end_time)
self.facts_changed()

def resume_tracking(self, no_gap=False):
"""Resume tracking the last activity"""
facts = self.__get_todays_facts()
if facts and facts[-1].end_time:
if no_gap:
self.__touch_fact(facts[-1], None)
else:
start_time = dt.datetime.now()
self.add_fact(facts[-1].copy(start_time=start_time,
end_time=None))
else:
logger.warning("No activity to resume")

def stop_or_restart_tracking(self):
"""Stops or restarts tracking the last activity"""
Expand Down

0 comments on commit ea53132

Please sign in to comment.