Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore AddFact compatibility #490

Merged
merged 1 commit into from
Dec 10, 2019

Conversation

ederag
Copy link
Collaborator

@ederag ederag commented Dec 10, 2019

DBus compatibility was lost, as reported by @jmberg in the shell-extension:
projecthamster/hamster-shell-extension#316 (comment)

This is a blind tentative to fix it.
(shell extension does not work here, and an earlier attempt to install it in an ubuntu virtualbox failed)

@jmberg
Copy link

jmberg commented Dec 10, 2019

Looks right, I'll test it in a minute.

@jmberg
Copy link

jmberg commented Dec 10, 2019

Yes, works for me with the gnome-shell-extension (that includes that other pull request)

@ederag ederag merged commit 448f86e into projecthamster:master Dec 10, 2019
@ederag ederag deleted the AddFact-compatibility branch December 10, 2019 21:32
@jmberg
Copy link

jmberg commented Dec 10, 2019

thanks :-)

@ederag
Copy link
Collaborator Author

ederag commented Dec 10, 2019

Thanks a lot for the feedback !
This was pulled in #482 as well, if you want to try it
(still need polishing, but hopefully better than master)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants