Code

Clients visibility#174

Code

Merged

Shatur merged 48 commits intomasterprojectharmonia/bevy_replicon:masterfrom clients-visibilityprojectharmonia/bevy_replicon:clients-visibilityCopy head branch name to clipboardJan 15, 2024

+1,080-38

Commits

Commits on Jan 13, 2024

• Initial prototype

  Shatur

  committed
  3b28b5b

• Fix tests compilation

  Shatur

  committed
  5767abe

Commits on Jan 14, 2024

• Do not panic on visibility change with ClientVisibility::All

  Shatur

  committed
  c1eea50

• Use proposed naming

  Shatur

  committed
  0b655e1

• Use more efficient iteration approach

  Shatur

  committed
  05cc66a

• Fix docs and add to prelude

  Shatur

  committed
  f3b5692

• Remove Box from iterator

  Shatur

  committed
  56c7880

• Export simpler visibility getter to users

  Shatur

  committed
  02a820e

• Combine loops

  Shatur

  committed
  222f63e

• Turn ClientVisibility into a struct with the inner enum

  Show description for 53cb84c
  Shatur

  committed
  53cb84c

• Refactor API to avoid extra lookup

  Shatur

  committed
  ebd9341

• Update docs

  Shatur

  committed
  a24fb9c

• Fix visibility check logic

  Shatur

  committed
  2e9e791

• Fix unhiding logic for blacklist

  Shatur

  committed
  e34fa97

• Put VisibilityPolicy to prelude

  Shatur

  committed
  ecc9f1e

• Add tests

  Shatur

  committed
  f10d0a1

• Improve docs

  Shatur

  committed
  f9e91b7

• Fix typo in the test

  Shatur

  committed
  a936335

• Refactor tests

  Show description for c8996ab
  Shatur

  committed
  c8996ab

• Apply suggestions from code review [skip ci]

  Show description for 64839be
  

  Shatur

  and

  UkoeHB

  authored
  64839be

• Apply more docs [skip ci]

  Show description for ac64583
  

  Shatur

  and

  UkoeHB

  authored
  ac64583

Commits on Jan 15, 2024

• Rename set_visible into set_visibility

  Shatur

  committed
  156d235

• Apply VisibilityFilter docs suggestions

  Shatur

  committed
  b63c8e1

• Apply suggested change to EntityState enum

  Shatur

  committed
  d7813f1

• Apply suggested naming about entity_state

  Shatur

  committed
  fc17651

• Fix remove_despawned logic

  Shatur

  committed
  7515312

• Add panicking versions for getting ClientInfo

  Shatur

  committed
  e6bac4b

• Use enums instead of bools

  Shatur

  committed
  b5071ab

• Write more comments about the logic

  Shatur

  committed
  2df564b

• Apply suggestions from code review [skip ci]

  Show description for 1f00634
  

  Shatur

  and

  UkoeHB

  authored
  1f00634

• Remove size_hint

  Show description for 643f2fc
  Shatur

  committed
  643f2fc

• Use drain instead of iteration

  Shatur

  committed
  9641dea

• Apply docs suggestions

  Shatur

  committed
  832bbca

• Fix warning about doc comment

  Shatur

  committed
  761254f

• Fix bug about re-adding in the list

  Shatur

  committed
  8497b87

• Refactor visibility logic as suggested

  Shatur

  committed
  ed3881b

• Clear removed and added in update too to avoid confusion

  Shatur

  committed
  f440312

• Add unit tests for many combinations and simplify integration tests

  Shatur

  committed
  bda6ac7

• Fix removal and insertion on the same tick

  Shatur

  committed
  a991a20

• Add more comments

  Shatur

  committed
  7696b53

• Apply clippy suggestion

  Shatur

  committed
  6b70f9c

• Add despawn tests

  Shatur

  committed
  2f9eefb

• Apply suggestions from code review

  Show description for 042097d
  

  Shatur

  and

  UkoeHB

  authored
  042097d

• Fix duplicate insertion for blacklist

  Shatur

  committed
  e35ed31

• Add whitelist despawn test

  Shatur

  committed
  c0b2d8a

• Simplify despawn tests

  Shatur

  committed
  b3ed333

• Add two more asserts

  Shatur

  committed
  6021346

• Use non-mut method

  Shatur

  committed
  6c87d2b