Replace deprecated utcnow() with now() #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto_rx/utils/plot_sonde_log.py
Outdated
| @@ -417,7 +417,7 @@ def process_directory(log_dir, output_dir, status_file, time_limit = 60): | |||
|
|
|||
|
|
|||
| # Calculate the age of the last data point in minutes. | |||
| _data_age = (pytz.utc.localize(datetime.datetime.utcnow()) - parse(last_time)).total_seconds() / 60.0 | |||
| _data_age = (pytz.utc.localize(datetime.datetime.now(datetime.timezone.utc)) - parse(last_time)).total_seconds() / 60.0 | |||
There was a problem hiding this comment.
This will need the pytz.utc.localize( ) call removed, as that expects a naive datetime object.
argilo
commented
Mar 27, 2024
| @@ -969,7 +969,7 @@ def sonde_search(self, first_only=False): | |||
| (_freq_decimate, _power_decimate) = peak_decimation(freq / 1e6, power, 10) | |||
| scan_result["freq"] = list(_freq_decimate) | |||
| scan_result["power"] = list(_power_decimate) | |||
| scan_result["timestamp"] = datetime.datetime.utcnow().isoformat() | |||
| scan_result["timestamp"] = datetime.datetime.now(datetime.timezone.utc).isoformat() | |||
There was a problem hiding this comment.
I noticed that this is going to change behaviour:
>>> datetime.datetime.utcnow().isoformat()
'2024-03-27T22:36:59.792134'
>>> datetime.datetime.now(datetime.timezone.utc).isoformat()
'2024-03-27T22:37:09.889948+00:00'
Maybe it should get a more specific time format?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Python 3.12,
datetime.utcnow()is deprecated, with the recommended replacement beingdatetime.now(timezone.utc). I made that replacement here. This was a simple search-and-replace, except inlistener_nmea_crlf.pywhere I modified the code to be more like the other scripts. So far I haven't done much testing apart from firing up auto_rx.