Don't update scan chart data until there's actual data #869
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the scan chart is open prior to the first scan being completed, an uncaught error occurs:
This occurs because the
scan_chart_*
variables are overwritten, even thoughget_scan_data
has not provided any data:radiosonde_auto_rx/auto_rx/autorx/templates/index.html
Lines 199 to 207 in d784d83
The
get_scan_data
response looks like so:Line 205 accesses non-existent array indices in
data.freq
, thereby setting the x coordinates of the threshold line toundefined
.To avoid this, we can skip processing if
data.freq
is empty, which leaves the placeholder data displayed instead.