Ensure that SSRC values are unique #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sonde frequencies should be limited to 7 digits, so SSRC values should be 9 digits at most, keeping them well below 2^32. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spectrum scanning doesn't work properly with ka9q-radio because Auto-RX chooses the same RTP SSRC number (which ka9q-radio uses as a channel identifier) for both SDR tests and spectrum scanning. The SSRC value must be a unique 32-bit integer.
Here I've changed the SSRC generation to use the frequency in kHz (rounded to the nearest integer) followed by two digits to indicate the channel type (01 for sonde reception, 02 for SDR tests, 03 for spectrum scanning). I hope this will ensure the uniqueness of SSRC values.