Java 9 Annotation Processing Broken #1472

gudenau · 2017-09-24T19:38:52Z

I am using Lombok 1.16.18 on JDK 9 and IntelliJ Idea 2017.2.4.

When using Lombok's annotation processor it causes the compiler to throw an exception.
Warning:(8, 8) java: lombok.javac.apt.LombokProcessor could not be initialized. Lombok will not run during this compilation: java.lang.IllegalArgumentException: com.sun.tools.javac.api.ClientCodeWrapper$WrappedStandardJavaFileManager extends com.sun.tools.javac.api.ClientCodeWrapper$WrappedJavaFileManager implements javax.tools.StandardJavaFileManager at lombok.javac.apt.LombokFileObjects.getCompiler(LombokFileObjects.java:130) at lombok.javac.apt.InterceptingJavaFileManager.<init>(InterceptingJavaFileManager.java:40) at lombok.javac.apt.LombokProcessor.placePostCompileAndDontMakeForceRoundDummiesHook(LombokProcessor.java:164) at lombok.javac.apt.LombokProcessor.init(LombokProcessor.java:85) at lombok.core.AnnotationProcessor$JavacDescriptor.want(AnnotationProcessor.java:87) at lombok.core.AnnotationProcessor.init(AnnotationProcessor.java:140) at lombok.launch.AnnotationProcessorHider$AnnotationProcessor.init(AnnotationProcessor.java:69) at jdk.compiler/com.sun.tools.javac.processing.JavacProcessingEnvironment$ProcessorState.<init>(JavacProcessingEnvironment.java:675) at jdk.compiler/com.sun.tools.javac.processing.JavacProcessingEnvironment$DiscoveredProcessors$ProcessorStateIterator.next(JavacProcessingEnvironment.java:774) at jdk.compiler/com.sun.tools.javac.processing.JavacProcessingEnvironment.discoverAndRunProcs(JavacProcessingEnvironment.java:869) at jdk.compiler/com.sun.tools.javac.processing.JavacProcessingEnvironment.access$2200(JavacProcessingEnvironment.java:108) at jdk.compiler/com.sun.tools.javac.processing.JavacProcessingEnvironment$Round.run(JavacProcessingEnvironment.java:1206) at jdk.compiler/com.sun.tools.javac.processing.JavacProcessingEnvironment.doProcessing(JavacProcessingEnvironment.java:1315) at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.processAnnotations(JavaCompiler.java:1246) at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:922) at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.lambda$doCall$0(JavacTaskImpl.java:100) at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.handleExceptions(JavacTaskImpl.java:142) at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.doCall(JavacTaskImpl.java:96) at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.call(JavacTaskImpl.java:90) at org.jetbrains.jps.javac.JavacMain.compile(JavacMain.java:190) at org.jetbrains.jps.incremental.java.JavaBuilder.compileJava(JavaBuilder.java:473) at org.jetbrains.jps.incremental.java.JavaBuilder.compile(JavaBuilder.java:328) at org.jetbrains.jps.incremental.java.JavaBuilder.doBuild(JavaBuilder.java:255) at org.jetbrains.jps.incremental.java.JavaBuilder.build(JavaBuilder.java:208) at org.jetbrains.jps.incremental.IncProjectBuilder.runModuleLevelBuilders(IncProjectBuilder.java:1260) at org.jetbrains.jps.incremental.IncProjectBuilder.runBuildersForChunk(IncProjectBuilder.java:937) at org.jetbrains.jps.incremental.IncProjectBuilder.buildTargetsChunk(IncProjectBuilder.java:1009) at org.jetbrains.jps.incremental.IncProjectBuilder.buildChunkIfAffected(IncProjectBuilder.java:900) at org.jetbrains.jps.incremental.IncProjectBuilder.buildChunks(IncProjectBuilder.java:733) at org.jetbrains.jps.incremental.IncProjectBuilder.runBuild(IncProjectBuilder.java:385) at org.jetbrains.jps.incremental.IncProjectBuilder.build(IncProjectBuilder.java:192) at org.jetbrains.jps.cmdline.BuildRunner.runBuild(BuildRunner.java:138) at org.jetbrains.jps.cmdline.BuildSession.runBuild(BuildSession.java:295) at org.jetbrains.jps.cmdline.BuildSession.run(BuildSession.java:125) at org.jetbrains.jps.cmdline.BuildMain$MyMessageHandler.lambda$channelRead0$0(BuildMain.java:236) at org.jetbrains.jps.service.impl.SharedThreadPoolImpl.lambda$executeOnPooledThread$0(SharedThreadPoolImpl.java:42) at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:514) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641) at java.base/java.lang.Thread.run(Thread.java:844)

The text was updated successfully, but these errors were encountered:

gudenau · 2017-09-24T19:51:24Z

Side note, I never realized how much I used Lombok until it broke. Most of my classes need changing to compile correctly without it!

Mart-Bogdan · 2017-09-25T08:23:32Z

Sadly it's using internal api, hope it would be fixed in few monthes, thankfully Java8 is still ok :-)

wrprice · 2017-09-25T18:01:07Z

I'm also getting what appears to be the same error, but using the command line and not IntelliJ.

Lombok edge 1.16.19 (2017-07-17 20:26:39 UTC)
JDK 9 GA Java HotSpot(TM) 64-Bit Server VM (build 9+181, mixed mode)
Gradle 4.2 2017-09-20 14:48:23 UTC
Win10 x64

I've opened the relevant modules/packages, and even tried --illegal-access=permit

warning: lombok.javac.apt.LombokProcessor could not be initialized. Lombok will not run during this compilation: java.lang.IllegalArgumentException: com.sun.tools.javac.api.ClientCodeWrapper$WrappedStandardJavaFileManager extends com.sun.tools.javac.api.ClientCodeWrapper$WrappedJavaFileManager implements javax.tools.StandardJavaFileManager
        at lombok.javac.apt.LombokFileObjects.getCompiler(LombokFileObjects.java:143)
        at lombok.javac.apt.InterceptingJavaFileManager.<init>(InterceptingJavaFileManager.java:40)
        at lombok.javac.apt.LombokProcessor.placePostCompileAndDontMakeForceRoundDummiesHook(LombokProcessor.java:164)
        at lombok.javac.apt.LombokProcessor.init(LombokProcessor.java:85)

I pulled down the current HEAD of the jdk9 branch and did some println debugging. In LombokFileObjects.java:115 there's an if branch checking class names for "c.s.t.j.api.ClientCodeWrapper$WrappedStandardJavaFileManager". We go into that branch, and the code expects the wrappedManager that it accessed via reflection to be an instance of com.sun.tools.javac.file.BaseFileManager.

On my machine, it turns out to be something different. Here's my debug output:

Wanted com.sun.tools.javac.file.BaseFileManager, but is: com.sun.proxy.$Proxy7
        super: java.lang.reflect.Proxy
        implements: [interface javax.tools.StandardJavaFileManager]

wrprice · 2017-09-26T17:34:47Z

I've got a bit of a hack workaround locally. Working on something I could submit as a starting point. (Need to go through a contribution process w/ my employer since it's on work time.)

This should be referenced from #985

…er for jdk9

tmurakam · 2017-10-15T14:07:14Z

I've created a patch to fix this issue.
The wrappedManager seems to be created with wrapWithCallDispatcher() of https://github.com/JetBrains/intellij-community/blob/master/jps/jps-builders-6/src/org/jetbrains/jps/javac/JavacMain.java
and it does not extends BaseFileManager. So it should be wrapped with another class extends BaseFileManager.

gudenau · 2017-10-25T19:38:46Z

Any news on when this will be on Maven?

rspilker · 2017-10-26T07:37:05Z

We've created an edge release. Can someone verify that this version fixes the problem?

rspilker · 2017-10-26T07:37:37Z

@gudenau We will make a new release after we get feedback on the edge release.

krzyk · 2017-10-26T07:53:24Z

Does it exist in any maven repo, or should I install it manually?

krzyk · 2017-10-26T08:42:49Z

@rspilker I can confirm that with edge release in IntelliJ IDEA 2013.3 EAP (Build #IU-173.3302.5, built on October 17, 2017) lombok annotations work fine.

rspilker · 2017-10-26T09:05:00Z

Thanks

thetric · 2017-10-26T09:52:49Z

The edge release unfortunately doesn't fix the Gradle build issue. The build still fails with the original stacktrace. (Built with Gradle 4.2.1, Java 9.0.1)

Edit: Seems to be my fault. In a fresh project the edge release works with Gradle + Jdk 9

lpandzic · 2017-10-26T14:52:02Z

@rspilker when can we expect a release? Do you need more verification?

wrprice · 2017-10-26T15:23:30Z

+1 the new edge release works with Gradle 4.2.1

gudenau · 2017-10-26T15:36:06Z

Sorry, I had other things to do.

How does one access the edge release?

krzyk · 2017-10-26T15:52:34Z

There is a link on lombok download page: https://projectlombok.org/download-edge

maistrovyi · 2017-10-26T18:28:19Z

@krzyk supra, thank you! What about maven repo?

gudenau · 2017-10-26T19:38:24Z

Interesting, I am getting an error regarding a javax error from modules not being visible.

Error:(17, 1) java: package javax.annotation is not visible
  (package javax.annotation is declared in module java.xml.ws.annotation, which is not in the module graph)

And the line with the error is

@ToString

on a class definition.

thetric · 2017-10-26T19:46:46Z

To fix this add this (assuming you're using gradle)

compileOnly 'javax.annotation:javax.annotation-api:1.3.1'

Or if you're using no build system: download this jar and add it to the buildpath

gudenau · 2017-10-26T20:03:46Z

I am using IntelliJ Idea, without a build system.

rspilker · 2017-10-26T20:19:53Z

To get rid of the javax.annotation problem, you could also create a lombok.config file, or download this one.

gudenau · 2017-10-26T21:56:29Z

So the latest edge build does work for me.

rspilker · 2017-10-26T22:08:08Z

@gudenau Can you tell me what version of IntelliJ you've used, so I can update the compatibility notes?

lpandzic · 2017-10-27T08:24:31Z

I've tested it and it works with IntelliJ 2017.2.

gudenau · 2017-10-27T17:04:39Z

IntelliJ Ultimate 2017.2.5.

kamilgregorczyk · 2017-11-03T17:53:20Z

When can we expect it to be in maven?

wrprice · 2017-11-09T22:13:37Z

@rspilker - My organization is eagerly waiting for 1.16.20 since we need the fixes in the current edge release but our policy prohibits depending upon what is effectively a snapshot. Since .18 is now four months old, is there anything else we can do to help unblock the release of .20?

sskorol · 2017-11-12T12:14:43Z

@wrprice could you please share your build.gradle configuration, which works for you with edge version?

wrprice · 2017-11-13T16:14:53Z

@sskorol - I can't share my entire project config, but these are the things I changed when I was initially trying to get it working:

dependencies {
    compileOnly files("path/to/lombok-edge.jar")
}

tasks.withType(JavaCompile) { // see note below
    options.fork = true
    options.forkOptions.jvmArgs += [
          '--add-opens', 'jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED',
          '--add-opens', 'jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED',
          '--add-opens', 'jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED',
          '--add-opens', 'jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED',
          '--add-opens', 'jdk.compiler/com.sun.tools.javac.model=ALL-UNNAMED',
          '--add-opens', 'jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED',
          '--add-opens', 'jdk.compiler/com.sun.tools.javac.processing=ALL-UNNAMED',
          '--add-opens', 'jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED',
          '--add-opens', 'jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED'
        ]
}

As a test, I just commented out the options.fork and options.forkOptions.jvmArgs and my build is still working on JDK 9 GA and Gradle 4.2.1 using the newer java-library plugin instead of the older java plugin. (shrug) So, with that combination of software, it seems to be simply a matter of applying the new Lombok jar.

krzyk · 2017-11-23T09:33:54Z

@rspilker Are more tests needed to confirm the fix for IntelliJ? Or there are other issues that are targeted for .20 release? We are eagerly awaiting new release so we can use Java 9 in projects with lombok.

rspilker · 2017-12-04T22:18:45Z

We're still finalizing jdk9 support.

slnowak · 2017-12-21T18:11:53Z

@rspilker can we expect it this year?

aalmazzo · 2017-12-25T08:04:11Z

+1 please support java9

jayantbit · 2017-12-31T06:41:40Z

+1
Lombok edge jar is working perfectly with gradle 4.2.1.
Please release it to maven central.

rspilker · 2018-01-08T23:58:37Z

1.16.20 has just been uploaded to our website and should be available on maven central soon.

gudenau · 2018-01-09T00:06:00Z

Cheers!

lpandzic · 2018-01-09T09:09:06Z

@rspilker, why was out of the box support for ConstructorProperties removed? It was working fine on edge release.

krzyk · 2018-01-09T09:46:04Z

I think lack of ConstructorProperties breaks behavior with deserialization with jackson. Is there a switch to bring it back?

lpandzic · 2018-01-09T09:47:16Z

Yes, this is exactly the issue I encountered, single parameter constructor doesn't work without an annotation.

krzyk · 2018-01-09T13:53:28Z

@lpandzic I found in the changelog that now we need to use lombok.anyConstructor.addConstructorProperties = true to have it work (and probably add java.desktop module)

rspilker · 2018-01-09T14:17:01Z

The reason it was removed by default is that it would break jdk9 compilation if you didn't specify the dependency on the extra module.

randakar · 2018-01-09T14:44:20Z

Damn. Would be nice to have that documented somewhere. I want to upgrade our projects to JDK 9 but gotcha's like that (we use Jackson, ofc) would make it more difficult. A small migration guide would help.

krzyk · 2018-01-09T14:58:15Z

@randakar https://projectlombok.org/changelog is not enough?

lpandzic · 2018-01-09T15:32:12Z

Well, for jackson, this was a hack anyway, we need real support like I've requested in this issue - FasterXML/jackson-databind#1498.
Thanks @rspilker .

randakar · 2018-01-09T17:00:18Z

@krzyk I guess you do have a point there. I was thinking along the lines of documenting what happens if you upgrade an existing JDK 8 / jackson project, but if it's just this one single thing I guess the changelog will have to do.

Arpit0492 · 2018-02-02T07:05:30Z

This worked for me mplushnikov/lombok-intellij-plugin#415

eximius313 · 2018-03-03T19:24:06Z

This comment could be related with this bug

gudenau changed the title ~~Java 9 @SneakyThrows Broken~~ Java 9 Annotations Broken Sep 24, 2017

gudenau changed the title ~~Java 9 Annotations Broken~~ Java 9 Annotation Processing Broken Sep 24, 2017

wrprice mentioned this issue Oct 4, 2017

Plugin fails project compilation with Java 9 mplushnikov/lombok-intellij-plugin#421

Closed

tmurakam added a commit to tmurakam/lombok that referenced this issue Oct 15, 2017

fix issue projectlombok#1440, projectlombok#1472: wrap BasedFileManag…

967b200

…er for jdk9

tmurakam added a commit to tmurakam/lombok that referenced this issue Oct 15, 2017

fix issue projectlombok#1440, projectlombok#1472: wrap BasedFileManag…

d92bc59

…er for jdk9

tmurakam mentioned this issue Oct 15, 2017

fix issue #1440, #1472: wrap BasedFileManager for jdk9 #1495

Merged

thetric mentioned this issue Oct 26, 2017

Gradle 4.1/4.2 cannot build lombok-processor required code with JDK 9 gradle/gradle#3012

Closed

rspilker closed this as completed Jan 9, 2018

reegnz mentioned this issue Jan 17, 2018

Annotation processing breaks with Java 9 querydsl/querydsl#2242

Closed

Java 9 Annotation Processing Broken #1472

Java 9 Annotation Processing Broken #1472

Comments

gudenau commented Sep 24, 2017 • edited Loading

gudenau commented Sep 24, 2017

Mart-Bogdan commented Sep 25, 2017

wrprice commented Sep 25, 2017 • edited Loading

wrprice commented Sep 26, 2017 • edited Loading

tmurakam commented Oct 15, 2017 • edited Loading

gudenau commented Oct 25, 2017

rspilker commented Oct 26, 2017

rspilker commented Oct 26, 2017

krzyk commented Oct 26, 2017

krzyk commented Oct 26, 2017

rspilker commented Oct 26, 2017

thetric commented Oct 26, 2017 • edited Loading

lpandzic commented Oct 26, 2017

wrprice commented Oct 26, 2017

gudenau commented Oct 26, 2017

krzyk commented Oct 26, 2017

maistrovyi commented Oct 26, 2017 • edited Loading

gudenau commented Oct 26, 2017

thetric commented Oct 26, 2017 • edited Loading

gudenau commented Oct 26, 2017 • edited Loading

rspilker commented Oct 26, 2017

gudenau commented Oct 26, 2017

rspilker commented Oct 26, 2017

lpandzic commented Oct 27, 2017 • edited Loading

gudenau commented Oct 27, 2017 • edited Loading

kamilgregorczyk commented Nov 3, 2017

wrprice commented Nov 9, 2017

sskorol commented Nov 12, 2017

wrprice commented Nov 13, 2017

krzyk commented Nov 23, 2017

rspilker commented Dec 4, 2017

slnowak commented Dec 21, 2017

aalmazzo commented Dec 25, 2017

jayantbit commented Dec 31, 2017

rspilker commented Jan 8, 2018

gudenau commented Jan 9, 2018

lpandzic commented Jan 9, 2018

krzyk commented Jan 9, 2018

lpandzic commented Jan 9, 2018 • edited Loading

krzyk commented Jan 9, 2018

rspilker commented Jan 9, 2018

randakar commented Jan 9, 2018

krzyk commented Jan 9, 2018

lpandzic commented Jan 9, 2018

randakar commented Jan 9, 2018

Arpit0492 commented Feb 2, 2018

eximius313 commented Mar 3, 2018

gudenau commented Sep 24, 2017 •

edited

Loading

wrprice commented Sep 25, 2017 •

edited

Loading

wrprice commented Sep 26, 2017 •

edited

Loading

tmurakam commented Oct 15, 2017 •

edited

Loading

thetric commented Oct 26, 2017 •

edited

Loading

maistrovyi commented Oct 26, 2017 •

edited

Loading

thetric commented Oct 26, 2017 •

edited

Loading

gudenau commented Oct 26, 2017 •

edited

Loading

lpandzic commented Oct 27, 2017 •

edited

Loading

gudenau commented Oct 27, 2017 •

edited

Loading

lpandzic commented Jan 9, 2018 •

edited

Loading