#2633 Split PatchDelegate into 2 classes, 1 without jdt.core deps.

[rgra]

Fixes #2633 by splitting up PatchDelegate into PatchDelegateChildren and delegating to it via an interface

[Rawi01]

• There should be a formatter profile if you import lombok in eclipse, can you use that one? Your current profile removed a lot of whitespace.
• New files should use only 2020 as copyright year.
• findAlreadyImplementedMethods is not an eclipse only method, disabling this in ecj mode will lead to inconsistent behaviour.
• I don't think that it is required to split up Reflection into two classes as long as getChildren is the second method in the static block.
• I don't think that it is required to split everything up into two classes, you can use the non existing class as long as you do not create an instance and do not looup the methods using reflection. It might be easier to move all eclipse only methods into a nested class e.g. EclipseOnlyMethods that detects if eclipse is available and if not all methods simply return null. Example:

private static class EclipseOnlyMethods {
	private static boolean eclipseAvailable = true;
	static {
		try {
			CompilationUnit.class.getName();
		} catch (NoClassDefFoundError e) {
			eclipseAvailable = false;
		}
	}
	private static List<SourceMethod> getDelegateMethods(SourceType sourceType) {
		if (!eclipseAvailable) return null;
		...
	}
	...
}

Disclaimer: I'm not a project owner.

[rzwitserloot]

@Rawi01 Given that you wrote in already-merged PR #2742 that that one 'fixes' this one, can I close this without merging it?

[Rawi01]

@rzwitserloot Yes, this PR can be closed. I missed to do that, sorry for wasting your time.