Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JSpecify annotation fully-qualified names #3608

Merged
merged 6 commits into from
Mar 1, 2024
Merged

Update JSpecify annotation fully-qualified names #3608

merged 6 commits into from
Mar 1, 2024

Conversation

jyoo980
Copy link
Contributor

@jyoo980 jyoo980 commented Feb 17, 2024 •
edited
Loading

Updates the HandlerUtil with the org.jspecify.annotations.NonNull annotation here

@msridhar
Copy link
Contributor

@jyoo980 what a coincidence, I just opened #3613 which does something similar but updates the copyable annotations. Do you want to just merge my commit into this PR and then I can close the other one?

@jyoo980
Copy link
Contributor Author

jyoo980 commented Feb 22, 2024

@msridhar sure, sounds good. I'll try to get your patch merged into mine today.

jyoo980
jyoo980 commented Feb 22, 2024
View reviewed changes
AUTHORS Outdated Show resolved Hide resolved
@jyoo980 jyoo980 mentioned this pull request Feb 22, 2024
Closed
@jyoo980
Copy link
Contributor Author

jyoo980 commented Feb 22, 2024 •
edited
Loading

Closes #3613

@msridhar
Copy link
Contributor

Thanks for merging in the other change so quick @jyoo980! We may also want to re-title this PR to capture the new scope

@jyoo980 jyoo980 changed the title Add jspecify @NonNull annotation Update JSpecify annotation fully-qualified names Feb 22, 2024
@jyoo980 jyoo980 requested a review from msridhar February 22, 2024 22:37
msridhar
msridhar approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@msridhar msridhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jyoo980
Copy link
Contributor Author

jyoo980 commented Feb 28, 2024

@Rawi01 is there anything else I can do to help get this PR merged?

@Rawi01 Rawi01 merged commit a5bb414 into projectlombok:master Mar 1, 2024
53 checks passed
@msridhar msridhar mentioned this pull request Mar 3, 2024
Closed
@rspilker
Copy link
Collaborator

This is part of the latest edge release, all feedback is welcome.

@zman0900 zman0900 mentioned this pull request Aug 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msridhar msridhar msridhar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jyoo980 @msridhar @rspilker @Rawi01