Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gis: Remove unique_id from Agent init #204

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

EwoutH
Copy link
Member

@EwoutH EwoutH commented Sep 25, 2024

Remove the unique_id from Agent init in the GIS models. This is now handled automatically in Mesa 3.0 (projectmesa/mesa#2260).

Follows #194.

@EwoutH EwoutH requested review from rht and wang-boyu September 25, 2024 10:44
Now handled automatically in Mesa 3.0
@EwoutH EwoutH force-pushed the gis_remove_unique_id branch from be87bdb to 617f36d Compare September 25, 2024 10:48
@EwoutH
Copy link
Member Author

EwoutH commented Sep 25, 2024

Resolves all warnings around unique_id, merging.

Post-merge review still appreciated!

@EwoutH EwoutH merged commit a3f20ae into projectmesa:main Sep 25, 2024
1 of 3 checks passed
@EwoutH EwoutH deleted the gis_remove_unique_id branch September 25, 2024 10:53
@EwoutH EwoutH restored the gis_remove_unique_id branch September 25, 2024 10:53
@EwoutH EwoutH deleted the gis_remove_unique_id branch September 25, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant