RasterLayer creates Cells, Cells inherit from Agents, Agents need model input, but RasterLayer doesn't have access to model

[EwoutH]

Currently, Mesa-Geo can create agents in it's RasterLayer's from_file() method.

mesa-geo/mesa_geo/raster_layers.py

Line 556 in 9c3196c

obj = cls(width, height, dataset.crs, total_bounds, cell_cls)

To create an Mesa Agent, you are required to pass a Model parameter:

https://github.com/projectmesa/mesa/blob/0b2d250cf2d3be79b266a04c0c91612880e28f0a/mesa/agent.py#L40

However, the RasterLayer or it's from_file() method don't have access to a Model variable.

---

Why this previously worked, I don't know exactly. I think because there was previously a "hack" in which you inherited from Agent, but not properly set the agent up with super().__init__().

I think this might require a rethink about how Cells integrate with the Mesa (with the AgentSet and experimental cell_space specifically.

[EwoutH]

(I deleted two spam posts from spam bots)

Edit: Three

[wang-boyu]

It's probably introduced as mentioned here: https://github.com/projectmesa/mesa-geo/pull/212/files#r1730417300

A model parameter was added to class constructor, but it wasn't added into the from_file class method:

mesa-geo/mesa_geo/raster_layers.py

Line 556 in 9c3196c

obj = cls(width, height, dataset.crs, total_bounds, cell_cls)

Moving forward, it's better to refactor RasterLayer based on PropertyLayer as mentioned in this ticket #201.

But I'll submit a fix for this first.

[EwoutH]

Thanks for looking into this!

It sparked me to finally write up an example model using the PropertyLayer: projectmesa/mesa-examples#182

[wang-boyu]

Great!