Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gis: Pass model to RasterLayer.from_file() #186

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

EwoutH
Copy link
Member

@EwoutH EwoutH commented Sep 2, 2024

Fixes the population and rainfall models by passing model to RasterLayer.from_file().

The RasterLayer creates Cells, Cells inherit from Agents, Agents need model input, but RasterLayer doesn't have access to model.

This reduces the number of GIS models that error by two, with now only one warning and one error left.

@EwoutH EwoutH added the gis label Sep 2, 2024
@EwoutH EwoutH requested a review from wang-boyu September 2, 2024 11:09
@EwoutH EwoutH mentioned this pull request Sep 2, 2024
31 tasks
@wang-boyu
Copy link
Member

Resolved conflicts with #184.

@wang-boyu
Copy link
Member

Hmm not sure why it's still showing "This branch cannot be rebased due to conflicts"

@EwoutH EwoutH merged commit 89f9379 into projectmesa:main Sep 2, 2024
1 of 3 checks passed
EwoutH added a commit to EwoutH/mesa-examples that referenced this pull request Sep 3, 2024
Fixes the population and rainfall models by passing model to RasterLayer.from_file().

> The RasterLayer creates Cells, Cells inherit from Agents, Agents need model input, but RasterLayer doesn't have access to model.
EwoutH added a commit to EwoutH/mesa-examples that referenced this pull request Sep 20, 2024
Fixes the population and rainfall models by passing model to RasterLayer.from_file().

> The RasterLayer creates Cells, Cells inherit from Agents, Agents need model input, but RasterLayer doesn't have access to model.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants